From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM list <kvm@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PULL] virtio/vhost: cross endian support
Date: Thu, 2 Jul 2015 08:12:37 +0200 [thread overview]
Message-ID: <20150702080916-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CA+55aFxNfhQv2G6ak4b1A7Tb7zn9E7xfq7N+Pak5RW7VPSb=Vw@mail.gmail.com>
On Wed, Jul 01, 2015 at 12:03:59PM -0700, Linus Torvalds wrote:
> On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Doing a unconditional byte swap is faster and simpler than the crazy
> > conditionals.
>
> Unconditional endianness not only makes for simpler and faster code,
> it also ends up being easier to debug and add things like type
> annotations for sparse.
>
> Linus
At least this last one is well covered by these patches: this uses
separate sparse types so all accesses are statically verified by sparse
to use the correct accessor.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM list <kvm@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
gkurz@linux.vnet.ibm.com, kraxel@redhat.com
Subject: Re: [PULL] virtio/vhost: cross endian support
Date: Thu, 2 Jul 2015 08:12:37 +0200 [thread overview]
Message-ID: <20150702080916-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CA+55aFxNfhQv2G6ak4b1A7Tb7zn9E7xfq7N+Pak5RW7VPSb=Vw@mail.gmail.com>
On Wed, Jul 01, 2015 at 12:03:59PM -0700, Linus Torvalds wrote:
> On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Doing a unconditional byte swap is faster and simpler than the crazy
> > conditionals.
>
> Unconditional endianness not only makes for simpler and faster code,
> it also ends up being easier to debug and add things like type
> annotations for sparse.
>
> Linus
At least this last one is well covered by these patches: this uses
separate sparse types so all accesses are statically verified by sparse
to use the correct accessor.
--
MST
next prev parent reply other threads:[~2015-07-02 6:12 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 9:31 [PULL] virtio/vhost: cross endian support Michael S. Tsirkin
2015-07-01 19:02 ` Linus Torvalds
2015-07-01 19:02 ` Linus Torvalds
2015-07-01 19:03 ` Linus Torvalds
2015-07-01 19:03 ` Linus Torvalds
2015-07-02 6:12 ` Michael S. Tsirkin [this message]
2015-07-02 6:12 ` Michael S. Tsirkin
2015-07-02 6:01 ` Michael S. Tsirkin
2015-07-02 6:01 ` Michael S. Tsirkin
2015-07-02 9:12 ` Greg Kurz
2015-07-02 9:12 ` Greg Kurz
2015-07-02 9:32 ` Michael S. Tsirkin
2015-07-02 9:32 ` Michael S. Tsirkin
2015-07-07 16:36 ` Thomas Huth
2015-07-07 16:36 ` Thomas Huth
2015-07-07 16:51 ` Michael S. Tsirkin
2015-07-07 16:51 ` Michael S. Tsirkin
2015-07-09 7:49 ` [PATCH] KVM: Add Kconfig option to signal cross-endian guests Thomas Huth
2015-07-09 7:49 ` Thomas Huth
2015-07-09 7:49 ` Thomas Huth
2015-07-09 7:49 ` Thomas Huth
2015-07-09 9:48 ` Laurent Vivier
2015-07-09 9:48 ` Laurent Vivier
2015-07-09 9:48 ` Laurent Vivier
2015-07-09 9:48 ` Laurent Vivier
2015-07-09 12:57 ` Paolo Bonzini
2015-07-09 12:57 ` Paolo Bonzini
2015-07-09 12:57 ` Paolo Bonzini
2015-07-09 12:57 ` Paolo Bonzini
2015-07-09 13:07 ` Michael S. Tsirkin
2015-07-09 13:07 ` Michael S. Tsirkin
2015-07-09 13:07 ` Michael S. Tsirkin
2015-07-09 13:07 ` Michael S. Tsirkin
2015-07-09 18:59 ` Thomas Huth
2015-07-09 18:59 ` Thomas Huth
2015-07-09 18:59 ` Thomas Huth
2015-07-09 18:59 ` Thomas Huth
2015-07-09 10:02 ` Christoffer Dall
2015-07-09 10:02 ` Christoffer Dall
2015-07-09 10:02 ` Christoffer Dall
2015-07-09 10:02 ` Christoffer Dall
2015-07-09 12:21 ` Cornelia Huck
2015-07-09 12:21 ` Cornelia Huck
2015-07-09 12:21 ` Cornelia Huck
2015-07-09 12:21 ` Cornelia Huck
2015-07-09 12:21 ` Cornelia Huck
2015-07-13 9:24 ` Greg Kurz
2015-07-13 9:24 ` Greg Kurz
2015-07-13 9:24 ` Greg Kurz
2015-07-13 9:24 ` Greg Kurz
2015-07-13 9:24 ` Greg Kurz
2015-07-03 7:59 ` [PULL] virtio/vhost: cross endian support Michael S. Tsirkin
2015-07-03 22:26 ` Linus Torvalds
2015-07-03 22:26 ` Linus Torvalds
2015-07-03 7:59 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2015-07-01 9:31 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702080916-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.