From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Date: Thu, 02 Jul 2015 12:31:30 +0000 Subject: Re: 4.1 regression in resizable hashtable tests Message-Id: <20150702123130.GA20843@pox.localdomain> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Meelis Roos Cc: sparclinux@vger.kernel.org, Linux Kernel list , netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Daniel Borkmann , Geert Uytterhoeven On 07/01/15 at 01:21pm, Meelis Roos wrote: > This is 4.1 on sparc64 - one of my boxes that happens to have most > runtime test left on from some debugging effort. In 4.0 it was fine, 4.1 > gives this in dmesg: > > [ 31.898697] Running resizable hashtable tests... > [ 31.898915] Adding 2048 keys > [ 31.952911] Traversal complete: counted, nelems 48, entries 48 > [ 31.953004] Test failed: Total count mismatch ^^^ > [ 32.022676] Traversal complete: counted, nelems 48, entries 48 > [ 32.022788] Test failed: Total count mismatch ^^^ > [ 32.022828] Deleting 2048 keys Thanks for the report. I think this is already fixed. Can you try with the following commit: commit 246b23a7695bd5a457aa51a36a948cce53d1d477 Author: Thomas Graf Date: Thu Apr 30 22:37:44 2015 +0000 rhashtable-test: Use walker to test bucket statistics As resizes may continue to run in the background, use walker to ensure we see all entries. Also print the encountered number of rehashes queued up while traversing. This may lead to warnings due to entries being seen multiple times. We consider them non-fatal. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750755AbbGBMbk (ORCPT ); Thu, 2 Jul 2015 08:31:40 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33345 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbbGBMbf (ORCPT ); Thu, 2 Jul 2015 08:31:35 -0400 Date: Thu, 2 Jul 2015 14:31:30 +0200 From: Thomas Graf To: Meelis Roos Cc: sparclinux@vger.kernel.org, Linux Kernel list , netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Daniel Borkmann , Geert Uytterhoeven Subject: Re: 4.1 regression in resizable hashtable tests Message-ID: <20150702123130.GA20843@pox.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/15 at 01:21pm, Meelis Roos wrote: > This is 4.1 on sparc64 - one of my boxes that happens to have most > runtime test left on from some debugging effort. In 4.0 it was fine, 4.1 > gives this in dmesg: > > [ 31.898697] Running resizable hashtable tests... > [ 31.898915] Adding 2048 keys > [ 31.952911] Traversal complete: counted=17, nelems=2048, entries=2048 > [ 31.953004] Test failed: Total count mismatch ^^^ > [ 32.022676] Traversal complete: counted=17, nelems=2048, entries=2048 > [ 32.022788] Test failed: Total count mismatch ^^^ > [ 32.022828] Deleting 2048 keys Thanks for the report. I think this is already fixed. Can you try with the following commit: commit 246b23a7695bd5a457aa51a36a948cce53d1d477 Author: Thomas Graf Date: Thu Apr 30 22:37:44 2015 +0000 rhashtable-test: Use walker to test bucket statistics As resizes may continue to run in the background, use walker to ensure we see all entries. Also print the encountered number of rehashes queued up while traversing. This may lead to warnings due to entries being seen multiple times. We consider them non-fatal. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller