Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Jul 02, 2015 at 05:14:02PM +0300, Pavel Fedin wrote:
> Instead of adding gic-version option, it is much easier to create a new machine
> type. The problem is mc->max_cpus. I tried to change this value inside property
> handling code, but it simply did not work, and i still got " Maximum CPUs
> greater than specified machine type limit" error from qemu. It looks like CPU
> number limitation is evaluated before machine is instantiated and properties
> are evaluated. It is possible to make a workaround, of course, but it seems to
> require much more changes than simply subclassing a machine.
> 
> This patch also introduces kernel_irqchip_type member in Machine class.
> Currently it it used only by virt machine for its internal purposes, however in
> future it is to be passed to KVM in kvm_irqchip_create(). The variable is
> defined as int in order to be architecture agnostic, for potential future
> users.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>

As mentioned in previous postings, this should be done as a property on
the existing machine type, not a new machine type.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|