From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH 3/3] mac80211: select an AID when creating new mesh STAs
Date: Thu, 2 Jul 2015 10:45:27 -0400 [thread overview]
Message-ID: <20150702144527.GA3846@localhost> (raw)
In-Reply-To: <1435843898.2285.24.camel@sipsolutions.net>
On Thu, Jul 02, 2015 at 03:31:38PM +0200, Johannes Berg wrote:
> On Thu, 2015-07-02 at 09:28 -0400, Bob Copeland wrote:
> >
> > + DECLARE_BITMAP(aid_map, IEEE80211_MAX_AID + 1);
> >
> Is there really much point in keeping a long-lived bitmap rather than
> iterating the existing stations when adding a new one? It's not such a
> frequent operation after all.
Not really -- I tried it both ways initially, and the bitmap ended up
with less code and u.mesh was still (slightly) smaller than u.mgd, but I
agree it does feel kind of bloaty so I'll prep a version the other way.
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2015-07-02 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:28 [PATCH 0/3] Mesh AID fixes Bob Copeland
2015-07-02 13:28 ` [PATCH 1/3] mac80211: reorder mesh_plink to remove forward decl Bob Copeland
2015-07-02 13:28 ` [PATCH 2/3] mac80211: mesh: separate plid and aid concepts Bob Copeland
2015-07-02 13:28 ` [PATCH 3/3] mac80211: select an AID when creating new mesh STAs Bob Copeland
2015-07-02 13:31 ` Johannes Berg
2015-07-02 14:45 ` Bob Copeland [this message]
2015-07-02 14:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702144527.GA3846@localhost \
--to=me@bobcopeland.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.