From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZAhFD-0007MX-Vw
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:21:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZAhF9-00041z-R4
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:21:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZAhF9-0003zz-LO
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:21:43 -0400
Date: Thu, 2 Jul 2015 17:21:37 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150702162137.GK1814@redhat.com>
References: <cover.1435844519.git.p.fedin@samsung.com>
	<7301d5cb99fe7d96090333fc697c8b1b2d6514a6.1435844519.git.p.fedin@samsung.com>
	<20150702142516.GG1814@redhat.com>
	<02da01d0b4d5$f68a31f0$e39e95d0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <02da01d0b4d5$f68a31f0$e39e95d0$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses
	GIC-500
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'Eric Auger' <eric.auger@linaro.org>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, qemu-devel@nongnu.org, 'Christoffer Dall' <christoffer.dall@linaro.org>

On Thu, Jul 02, 2015 at 05:47:04PM +0300, Pavel Fedin wrote:
>  Hello!
> 
>  I already explained this earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04842.html, and i tried to explain this in commit message. Current qemu architecture does not allow doing this in a clean way.
>  I can simply change mc->max_cpus for 'virt' machine to 64 (always), and
>  then check user-supplied value against GIC limitation by myself. And
>  produce error. This will be code duplication. Do you think it is better?
>  Anybody else (Peter, Cristoffer ?), please vote.

Yes, just increase the declared max cpus to the larger of the two values,
and do a manual check at time of use

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|