All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: "Huang, Jie (Jackie)" <Jackie.Huang@windriver.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] xorg-proto-common: allow the empty package
Date: Fri, 3 Jul 2015 11:04:05 +0200	[thread overview]
Message-ID: <20150703090405.GA2436@jama> (raw)
In-Reply-To: <1B858668EC6A94408DCA5225FDFA85AAF11F6D32@ALA-MBB.corp.ad.wrs.com>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

On Fri, Jul 03, 2015 at 01:34:31AM +0000, Huang, Jie (Jackie) wrote:
> Yeah I know it’s not good to have the empty package and we can remove dependencies to void error, but
> our customer may add the package through IMAGE_INSTALL in local.conf and blame it fails until do_rootfs:
> 
> ERROR: bigreqsproto not found in the base feeds (intel_x86_64 core2-64 x86_64 noarch any all).
> 
> Do we have a way to find out a PN package is empty at an earlier time so that we may warn the user not
> to add this package into image?

I as a customer would definitely prefer error message even later in the
build then getting completely useless empty package installed in my
image and blame you for installing it when I was expecting to find
bigreqsproto in my rootfs.

> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Friday, July 03, 2015 3:40 AM
> To: Huang, Jie (Jackie)
> Cc: OE-core
> Subject: Re: [OE-core] [PATCH] xorg-proto-common: allow the empty package
> 
> 
> On 1 July 2015 at 08:52, <jackie.huang@windriver.com<mailto:jackie.huang@windriver.com>> wrote:
>  # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
> +# and allow ${PN} to be created empty
> +ALLOW_EMPTY_${PN} = "1"
>  RDEPENDS_${PN}-dev = ""
>  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> 
> As the comment and surrounding lines state, the dependencies on PN from PN-dev and PN-dbg are already removed.  What other package has a runtime dependency on PN, and when you find it a better solution is to remove the dependency instead of creating empty packages.
> 
> Ross

> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2015-07-03  9:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  7:52 [PATCH] xorg-proto-common: allow the empty package jackie.huang
2015-07-02 19:39 ` Burton, Ross
2015-07-03  1:34   ` Huang, Jie (Jackie)
2015-07-03  9:04     ` Martin Jansa [this message]
2015-07-03  9:13       ` Burton, Ross
2015-07-03  9:34         ` Huang, Jie (Jackie)
2015-07-03  9:38           ` Burton, Ross
2015-07-03 10:16             ` Huang, Jie (Jackie)
2015-07-03 10:26               ` Burton, Ross
2015-07-03 10:34               ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703090405.GA2436@jama \
    --to=martin.jansa@gmail.com \
    --cc=Jackie.Huang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.