All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: minyard@acm.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU
Date: Fri, 3 Jul 2015 10:23:41 +0200	[thread overview]
Message-ID: <20150703102317-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1433812331-18993-1-git-send-email-minyard@acm.org>

On Mon, Jun 08, 2015 at 08:11:55PM -0500, minyard@acm.org wrote:
> I have reworked the QEMU IPMI patches, and I believe this design
> improves greatly on the previous one.  The suggestions made all
> resulted in better design.  To start an IPMI interface
> with this, you would use:
> 
>   -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0
> 
> Note that I did not make the BMCs objects.  I started this way, but
> adding properties was ending up duplicating a lot of code already
> in the device core, especially for the chardev link.
> 
> I'm not sure of the importance of having a BMC be an object instead
> of a device, but it seems to me that if we do that, it would be
> best to add helper functions to the object core for the chardev
> and integer properties.
> 
> Thanks,
> 
> -corey

In the future pls remember to copy maintainers on patches you post.

      parent reply	other threads:[~2015-07-03  8:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  1:11 [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU minyard
2015-06-09  1:11 ` [Qemu-devel] [PATCH v3 01/16] Add a base IPMI interface minyard
2015-06-09  1:11 ` [Qemu-devel] [PATCH v3 02/16] ipmi: Add a local BMC simulation minyard
2015-06-09  1:11 ` [Qemu-devel] [PATCH v3 03/16] ipmi: Add an external connection simulation interface minyard
2015-06-09  1:11 ` [Qemu-devel] [PATCH v3 04/16] ipmi: Add an ISA KCS low-level interface minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 05/16] ipmi: Add a BT " minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 06/16] ipmi: Add tests minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 07/16] ipmi: Add documentation minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 08/16] ipmi: Add migration capability to the IPMI devices minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 09/16] ipmi: Add a firmware configuration repository minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 10/16] ipmi: Add firmware registration to the ISA interface minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 11/16] smbios: Add a function to directly add an entry minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 12/16] pc: Postpone SMBIOS table installation to post machine init minyard
2015-07-03  8:17   ` Michael S. Tsirkin
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 13/16] ipmi: Add SMBIOS table entry minyard
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables minyard
2015-07-03  8:21   ` Michael S. Tsirkin
2015-07-03  8:27   ` Michael S. Tsirkin
2015-07-07  8:08   ` Igor Mammedov
2015-07-08 17:44     ` Paolo Bonzini
2015-07-08 19:26       ` Igor Mammedov
2015-07-08 20:39         ` Paolo Bonzini
2015-07-09  8:25           ` Igor Mammedov
2015-07-13 21:55             ` Corey Minyard
2015-07-14  7:36               ` Igor Mammedov
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 15/16] ipmi: Add ACPI table entries minyard
2015-07-07  9:47   ` Igor Mammedov
2015-06-09  1:12 ` [Qemu-devel] [PATCH v3 16/16] bios: Add tests for the IPMI ACPI and SMBIOS entries minyard
2015-07-03  0:30 ` [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU Benjamin Herrenschmidt
2015-07-03  6:50 ` Paolo Bonzini
2015-07-03  8:23 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703102317-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=minyard@acm.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.