From: Lee Jones <lee.jones@linaro.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support
Date: Fri, 3 Jul 2015 16:19:23 +0100 [thread overview]
Message-ID: <20150703151923.GB10500@x1> (raw)
In-Reply-To: <afbda3c9439f08cbf57c184ff6b96bdf7f5ca8b4.1435308209.git.Adam.Thomson.Opensource@diasemi.com>
On Fri, 26 Jun 2015, Adam Thomson wrote:
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> Documentation/devicetree/bindings/mfd/da9150.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt b/Documentation/devicetree/bindings/mfd/da9150.txt
> index d0588ea..8bf1a20 100644
> --- a/Documentation/devicetree/bindings/mfd/da9150.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9150.txt
> @@ -6,6 +6,7 @@ Device Description
> ------ -----------
> da9150-gpadc : General Purpose ADC
> da9150-charger : Battery Charger
> +da9150-fg : Battery Fuel-Gauge
>
> ======
>
> @@ -22,6 +23,7 @@ Required properties:
> Sub-devices:
> - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt
> - da9150-charger: See Documentation/devicetree/bindings/power/da9150-charger.txt
> +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt
Can you send a subsequent patch doing:
s-Documentation/devicetree/bindings/-../-
>
>
Superfluous '\n' here.
> Example:
> @@ -40,4 +42,8 @@ Example:
> da9150-charger {
> ...
> };
> +
> + da9150-fg {
> + ...
> + };
Perhaps a little content wouldn't go amiss here for quick reference.
Saves dipping in and out of the other binding files.
This patch is fine though:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-07-03 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 8:47 [PATCH v2 0/4] Add support for DA9150 Fuel-Gauge Adam Thomson
2015-06-26 8:47 ` Adam Thomson
2015-06-26 8:47 ` [PATCH v2 1/4] mfd: da9150: Add support for Fuel-Gauge Adam Thomson
2015-06-26 8:47 ` Adam Thomson
2015-07-03 15:16 ` Lee Jones
2015-07-06 14:03 ` Opensource [Adam Thomson]
2015-07-06 14:03 ` Opensource [Adam Thomson]
2015-06-26 8:47 ` [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support Adam Thomson
2015-06-26 8:47 ` Adam Thomson
2015-07-03 15:19 ` Lee Jones [this message]
2015-07-06 14:23 ` Opensource [Adam Thomson]
2015-07-06 14:23 ` Opensource [Adam Thomson]
2015-06-26 8:47 ` [PATCH v2 3/4] power: Add support for DA9150 Fuel-Gauge Adam Thomson
2015-06-26 8:47 ` Adam Thomson
2015-07-03 15:22 ` Lee Jones
2015-07-06 14:27 ` Opensource [Adam Thomson]
2015-07-06 14:27 ` Opensource [Adam Thomson]
2015-07-07 6:58 ` Lee Jones
2015-06-26 8:47 ` [PATCH v2 4/4] power: da9150: Add DT bindings documentation for Fuel-Gauge Adam Thomson
2015-06-26 8:47 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703151923.GB10500@x1 \
--to=lee.jones@linaro.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.