All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: reserve hole in the migration to non-extent based file
Date: Sat, 4 Jul 2015 00:33:29 -0400	[thread overview]
Message-ID: <20150704043329.GS9456@thunk.org> (raw)
In-Reply-To: <1435942311-2337-3-git-send-email-guaneryu@gmail.com>

Applied, although I reworded the commit description a little:

ext4: correctly migrate a file with a hole at the beginning

Currently ext4_ind_migrate() doesn't correctly handle a file which
contains a hole at the beginning of the file.  This caused the migration
to be done incorrectly, and then if there is a subsequent following
delayed allocation write to the "hole", this would reclaim the same data
blocks again and results in fs corruption.

...

Thanks!!

					- Ted

  reply	other threads:[~2015-07-04  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03 16:51 [PATCH 0/2] fix ext4 i_blocks corruption in generic/269 Eryu Guan
2015-07-03 16:51 ` [PATCH 1/2] ext4: be more strict when migrating to non-extent based file Eryu Guan
2015-07-04  4:04   ` Theodore Ts'o
2015-07-03 16:51 ` [PATCH 2/2] ext4: reserve hole in the migration " Eryu Guan
2015-07-04  4:33   ` Theodore Ts'o [this message]
2015-07-04 16:05     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150704043329.GS9456@thunk.org \
    --to=tytso@mit.edu \
    --cc=guaneryu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.