All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 6/7] package/opencv: add opengl support
Date: Sun, 5 Jul 2015 11:27:19 +0200	[thread overview]
Message-ID: <20150705092718.GF3647@free.fr> (raw)
In-Reply-To: <1436036821-10073-7-git-send-email-s.martin49@gmail.com>

Samuel, All,

On 2015-07-04 21:07 +0200, Samuel Martin spake thusly:
> In OpenCV, OpenGL is only used by highgui module.
> 
> OpenGL support is done using extensions from 3rd party framework: either
> Qt5OpenGL with Qt5 (with GL support only, not GLES); or gtkglext (which
> is not available in Buildroot) with gtk2
> 
> So, make OpenGL knob a sub-option of the Qt5 support option.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
[--SNIP--]
> diff --git a/package/opencv/opencv.mk b/package/opencv/opencv.mk
> index 986e7b4..61a3ccd 100644
> --- a/package/opencv/opencv.mk
> +++ b/package/opencv/opencv.mk
> @@ -264,6 +264,13 @@ else
>  OPENCV_CONF_OPTS += -DWITH_JPEG=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_OPENCV_WITH_OPENGL),y)
> +OPENCV_CONF_OPTS += -DWITH_OPENGL=ON
> +OPENCV_DEPENDENCIES += libgl qt5base

No need for qt5base here, since gl is already conditional to Qt5.

With that fixed:

    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> +else
> +OPENCV_CONF_OPTS += -DWITH_OPENGL=OFF
> +endif
> +
>  OPENCV_CONF_OPTS += -DWITH_OPENMP=$(if $(BR2_GCC_ENABLE_OPENMP),ON,OFF)
>  
>  ifeq ($(BR2_PACKAGE_OPENCV_WITH_PNG),y)
> -- 
> 2.4.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-07-05  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-04 19:06 [Buildroot] [PATCH v7 0/7] OpenCV bump Samuel Martin
2015-07-04 19:06 ` [Buildroot] [PATCH v7 1/7] package/opencv: add a choice for selecting gstreamer support Samuel Martin
2015-07-05  8:35   ` Yann E. MORIN
2015-07-04 19:06 ` [Buildroot] [PATCH v7 2/7] package/opencv: add gstreamer-1.x support Samuel Martin
2015-07-05  8:45   ` Yann E. MORIN
2015-07-05  9:10     ` Samuel Martin
2015-07-04 19:06 ` [Buildroot] [PATCH v7 3/7] package/opencv: add a choice for selecting the gui toolkit Samuel Martin
2015-07-05  8:49   ` Yann E. MORIN
2015-07-04 19:06 ` [Buildroot] [PATCH v7 4/7] package/opencv: add qt5 support Samuel Martin
2015-07-05  9:11   ` Yann E. MORIN
2015-07-04 19:06 ` [Buildroot] [PATCH v7 5/7] package/opencv: add gtk3 support Samuel Martin
2015-07-05  9:21   ` Yann E. MORIN
2015-07-05  9:31     ` Samuel Martin
2015-07-04 19:07 ` [Buildroot] [PATCH v7 6/7] package/opencv: add opengl support Samuel Martin
2015-07-05  9:27   ` Yann E. MORIN [this message]
2015-07-04 19:07 ` [Buildroot] [PATCH v7 7/7] package/vlc: add opencv support Samuel Martin
2015-07-05  9:39   ` Yann E. MORIN
2015-07-05  9:49     ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150705092718.GF3647@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.