From: Jeff King <peff@peff.net>
To: Chris Jones <chris@christopherjones.us>
Cc: git@vger.kernel.org, gitster@pobox.com, johannes.schindelin@gmx.de
Subject: Re: [PATCH] git-filter-branch.sh: clarify an error message
Date: Sun, 5 Jul 2015 09:07:07 -0400 [thread overview]
Message-ID: <20150705130706.GA5435@peff.net> (raw)
In-Reply-To: <1436053144.3463091.315316457.1BAF8BA7@webmail.messagingengine.com>
On Sat, Jul 04, 2015 at 07:39:04PM -0400, Chris Jones wrote:
> Make git filter-branch output a useful error message when a single
> commit is given instead of a range. Currently, when given a command
> like git filter-branch --msg-filter 'echo "TEST"' -- abc123, it will
> give the message "Which ref do you want to rewrite?". Instead, what
> is needed is a range of commits to rewrite. This makes it give an
> error message that says "You didn't provide a valid range of
> commits".
Yeah, I agree the current message is a little confusing, and I think
your message is an improvement. I wonder if we can even go a step
further, like mentioning that at least one of the positive tips in your
range must be a ref.
-Peff
next prev parent reply other threads:[~2015-07-05 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 23:39 [PATCH] git-filter-branch.sh: clarify an error message Chris Jones
2015-07-05 13:07 ` Jeff King [this message]
2015-07-05 14:41 ` Johannes Schindelin
2015-07-11 2:04 ` Chris Jones
2015-07-11 8:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705130706.GA5435@peff.net \
--to=peff@peff.net \
--cc=chris@christopherjones.us \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.