From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH] thermal: consistently use int for temperatures Date: Mon, 06 Jul 2015 12:26:40 +0200 Message-ID: <20150706122640.2a61ca05@amdc2363> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:39432 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbGFK0x convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 06:26:53 -0400 In-reply-to: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Jean Delvare , Peter Feuerer , Heiko Stuebner , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org Hi Sascha, > The thermal code uses int, long and unsigned long for temperatures > in different places. >=20 > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0=C2=B0C. This will > probably immediately shut the machine down due to overtemperature if > started below 0=C2=B0C. >=20 > 'long' is 64bit on several architectures. This is not needed since > INT_MAX =C2=B0mC is above the melting point of all known materials. >=20 > Consistently use a plain 'int' for temperatures throughout the > thermal code and the drivers. This only changes the places in the > drivers where the temperature is passed around as pointer, when > drivers internally use another type this is not changed. >=20 > Signed-off-by: Sascha Hauer Sascha, thanks for this cleanup work.=20 Reviewed-by: Lukasz Majewski --=20 Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 06 Jul 2015 10:26:40 +0000 Subject: Re: [lm-sensors] [PATCH] thermal: consistently use int for temperatures Message-Id: <20150706122640.2a61ca05@amdc2363> List-Id: References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Jean Delvare , Peter Feuerer , Heiko Stuebner , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org SGkgU2FzY2hhLAoKPiBUaGUgdGhlcm1hbCBjb2RlIHVzZXMgaW50LCBsb25nIGFuZCB1bnNpZ25l ZCBsb25nIGZvciB0ZW1wZXJhdHVyZXMKPiBpbiBkaWZmZXJlbnQgcGxhY2VzLgo+IAo+IFVzaW5n IGFuIHVuc2lnbmVkIHR5cGUgbGltaXRzIHRoZSB0aGVybWFsIGZyYW1ld29yayB0byBwb3NpdGl2 ZQo+IHRlbXBlcmF0dXJlcyB3aXRob3V0IG5lZWQuIEFsc28gc2V2ZXJhbCBkcml2ZXJzIGN1cnJl bnRseSB3aWxsIHJlcG9ydAo+IHRlbXBlcmF0dXJlcyBuZWFyIFVJTlRfTUFYIGZvciB0ZW1wZXJh dHVyZXMgYmVsb3cgMMKwQy4gVGhpcyB3aWxsCj4gcHJvYmFibHkgaW1tZWRpYXRlbHkgc2h1dCB0 aGUgbWFjaGluZSBkb3duIGR1ZSB0byBvdmVydGVtcGVyYXR1cmUgaWYKPiBzdGFydGVkIGJlbG93 IDDCsEMuCj4gCj4gJ2xvbmcnIGlzIDY0Yml0IG9uIHNldmVyYWwgYXJjaGl0ZWN0dXJlcy4gVGhp cyBpcyBub3QgbmVlZGVkIHNpbmNlCj4gSU5UX01BWCDCsG1DIGlzIGFib3ZlIHRoZSBtZWx0aW5n IHBvaW50IG9mIGFsbCBrbm93biBtYXRlcmlhbHMuCj4gCj4gQ29uc2lzdGVudGx5IHVzZSBhIHBs YWluICdpbnQnIGZvciB0ZW1wZXJhdHVyZXMgdGhyb3VnaG91dCB0aGUKPiB0aGVybWFsIGNvZGUg YW5kIHRoZSBkcml2ZXJzLiBUaGlzIG9ubHkgY2hhbmdlcyB0aGUgcGxhY2VzIGluIHRoZQo+IGRy aXZlcnMgd2hlcmUgdGhlIHRlbXBlcmF0dXJlIGlzIHBhc3NlZCBhcm91bmQgYXMgcG9pbnRlciwg d2hlbgo+IGRyaXZlcnMgaW50ZXJuYWxseSB1c2UgYW5vdGhlciB0eXBlIHRoaXMgaXMgbm90IGNo YW5nZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2FzY2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJv bml4LmRlPgoKU2FzY2hhLCB0aGFua3MgZm9yIHRoaXMgY2xlYW51cCB3b3JrLiAKClJldmlld2Vk LWJ5OiBMdWthc3ogTWFqZXdza2kgPGwubWFqZXdza2lAc2Ftc3VuZy5jb20+CgotLSAKQmVzdCBy ZWdhcmRzLAoKTHVrYXN6IE1hamV3c2tpCgpTYW1zdW5nIFImRCBJbnN0aXR1dGUgUG9sYW5kIChT UlBPTCkgfCBMaW51eCBQbGF0Zm9ybSBHcm91cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0Bs bS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5m by9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 From: l.majewski@samsung.com (Lukasz Majewski) Date: Mon, 06 Jul 2015 12:26:40 +0200 Subject: [PATCH] thermal: consistently use int for temperatures In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Message-ID: <20150706122640.2a61ca05@amdc2363> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sascha, > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0?C. This will > probably immediately shut the machine down due to overtemperature if > started below 0?C. > > 'long' is 64bit on several architectures. This is not needed since > INT_MAX ?mC is above the melting point of all known materials. > > Consistently use a plain 'int' for temperatures throughout the > thermal code and the drivers. This only changes the places in the > drivers where the temperature is passed around as pointer, when > drivers internally use another type this is not changed. > > Signed-off-by: Sascha Hauer Sascha, thanks for this cleanup work. Reviewed-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754580AbbGFK1A (ORCPT ); Mon, 6 Jul 2015 06:27:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:39432 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbGFK0x convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 06:26:53 -0400 X-AuditID: cbfee61a-f79516d000006302-1e-559a57eb056a Date: Mon, 06 Jul 2015 12:26:40 +0200 From: Lukasz Majewski To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Jean Delvare , Peter Feuerer , Heiko Stuebner , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org Subject: Re: [PATCH] thermal: consistently use int for temperatures Message-id: <20150706122640.2a61ca05@amdc2363> In-reply-to: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Organization: SPRC Poland X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jQd3X4bNCDZ6+FbToWmhgMf/KNVaL /49es1osvfuJzWL5vn5Gi02PgWKXd81hs5i9pJ/F4nPvEUaLGef3MVk8WXiGyeLOtL1sFls3 7WW2uHAhxmL1nhfMFmdOX2K1ePKwj83i7/ZNLBavDraxWPzcNY/FQcTjyaaLjB47Z91l99i8 Qstj8Z6XTB6bl9R7PJi4m82j/6+Bx4/Lb1g9tlxtZ/HY+b2B3WP7tXnMHptPV3t83iTnsXFu aABfFJdNSmpOZllqkb5dAlfG7TfL2AqucVRMWLKBuYGxh72LkZNDQsBEYs/z06wQtpjEhXvr 2boYuTiEBKYzSvy80soEkhASeMMo8X2zAYjNIqAq0bPtHzOIzSagJ/H57lOwGhEBTYlFCyYw gzQzC6xnldi14AILSEJYwFniwIHtjF2MHBy8QA39FzRBwpwC7hJLN01ggZjvJnG2YyPYEfwC khLt/34wQxxkJ3Hu0wawQ3kFBCV+TL4HVs8soC4xad4iZghbW+LJuwusExgFZyEpm4WkbBaS sgWMzKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgmP5mdQOxpUNFocYBTgYlXh4N9TNDBVi TSwrrsw9xCjBwawkwlvtMytUiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/JfJ9QIYH0xJLU7NTU gtQimCwTB6dUA+Mlp/kdOVPt9mtLsV96HFa9W+eG5M8jteJ5C7vKJog/2W3cfytsYSHnqvd/ 4lZwPni4aNKGqwv33NOa7LD4/Y+jpZ6X/IPK+yZ8ODC5+vftNr6CrkfzDu+bLeqz+lRW0O6S P0zzJ29K6HA+eSrQYK/sFqPDfj93/pJattPEquzZvu7vOcLr6l0jlFiKMxINtZiLihMBnnrv h+ECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sascha, > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0°C. This will > probably immediately shut the machine down due to overtemperature if > started below 0°C. > > 'long' is 64bit on several architectures. This is not needed since > INT_MAX °mC is above the melting point of all known materials. > > Consistently use a plain 'int' for temperatures throughout the > thermal code and the drivers. This only changes the places in the > drivers where the temperature is passed around as pointer, when > drivers internally use another type this is not changed. > > Signed-off-by: Sascha Hauer Sascha, thanks for this cleanup work. Reviewed-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group