From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/4] stm32f429-discovery: add CONFIG_SYS_THUMB_BUILD
Date: Mon, 6 Jul 2015 13:38:21 +0200 [thread overview]
Message-ID: <20150706133821.3cf07cb8@lilith> (raw)
In-Reply-To: <1436109227-10790-2-git-send-email-albert.u.boot@aribaud.net>
On Sun, 5 Jul 2015 17:13:44 +0200, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
> This target is ARMv7 therefore can only build for Thumb,
> but it did not #define CONFIG_SYS_THUMB_BUILD, so the U-Boot
> code did not know it had to build for Thumb(2), not ARM.
>
> This patch is binary-invariant: builds of stm32f429-discovery
> with and without this patch were compared and found to differ
> only by their U-Boot version strings.
>
> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>
> Changes in v4:
> - Made stm32f429-discovery explicitly state that it builds
> for Thumb
>
> Changes in v3: None
> Changes in v2: None
>
> include/configs/stm32f429-discovery.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
> index 46869dd..e2583f0 100644
> --- a/include/configs/stm32f429-discovery.h
> +++ b/include/configs/stm32f429-discovery.h
> @@ -9,6 +9,7 @@
> #define __CONFIG_H
>
> #define CONFIG_STM32F4
> +#define CONFIG_SYS_THUMB_BUILD
> #define CONFIG_STM32F4DISCOVERY
> #define CONFIG_SYS_GENERIC_BOARD
>
> --
> 2.1.0
>
Applied to u-boot-arm/master.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-07-06 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 15:13 [U-Boot] [PATCH v4 0/4] Add support for Thumb-1 builds Albert ARIBAUD
2015-07-05 15:13 ` [U-Boot] [PATCH v4 1/4] stm32f429-discovery: add CONFIG_SYS_THUMB_BUILD Albert ARIBAUD
2015-07-05 16:33 ` Albert ARIBAUD
2015-07-06 6:58 ` Kamil Lulko
2015-07-06 7:19 ` Albert ARIBAUD
2015-07-06 11:38 ` Albert ARIBAUD [this message]
2015-07-05 15:13 ` [U-Boot] [PATCH v4 2/4] arm: support Thumb-1 with CONFIG_SYS_THUMB_BUILD Albert ARIBAUD
2015-07-06 11:48 ` Albert ARIBAUD
2015-07-05 15:13 ` [U-Boot] [PATCH v4 3/4] kirkwood: support CONFIG_SYS_THUMB_BUILD Albert ARIBAUD
2015-07-06 11:49 ` Albert ARIBAUD
2015-07-05 15:13 ` [U-Boot] [PATCH v4 4/4] openrd: switch to CONFIG_SYS_THUMB_BUILD Albert ARIBAUD
2015-07-06 11:49 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706133821.3cf07cb8@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.