From: Dan Carpenter <dan.carpenter@oracle.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support
Date: Mon, 06 Jul 2015 15:35:02 +0000 [thread overview]
Message-ID: <20150706153502.GA22265@mwanda> (raw)
Hello Peter Hung,
The patch b7bca9b681e3: "hwmon: (f71882fg) Add f81866/f71868 SuperIO
support" from Jun 30, 2015, leads to the following static checker
warning:
drivers/hwmon/f71882fg.c:2425 f71882fg_probe()
warn: buffer overflow 'fxxxx_in_attr' 9 <= 9
drivers/hwmon/f71882fg.c
2422 for (i = 0; i < F71882FG_MAX_INS; i++) {
^^^^^^^^^^^^^^^^
We increased this from 9 to 10.
2423 if (f71882fg_has_in[data->type][i]) {
2424 err = device_create_file(&pdev->dev,
2425 &fxxxx_in_attr[i].dev_attr);
^^^^^^^^^^^^^^^^
But this array still only has 9 elements.
2426 if (err)
2427 goto exit_unregister_sysfs;
2428 }
2429 }
regards,
dan carpenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2015-07-06 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 15:35 Dan Carpenter [this message]
2015-07-06 21:59 ` [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support Guenter Roeck
2015-07-07 1:19 ` Peter Hung
2015-07-07 1:30 ` Peter Hung
2015-07-07 4:16 ` Guenter Roeck
2015-07-07 7:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706153502.GA22265@mwanda \
--to=dan.carpenter@oracle.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.