From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mike Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Boris BREZILLON <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage
Date: Mon, 6 Jul 2015 22:38:11 +0200 [thread overview]
Message-ID: <20150706203811.GC3127@piout.net> (raw)
In-Reply-To: <1436211105-10491-1-git-send-email-sboyd@codeaurora.org>
Hi,
On 06/07/2015 at 12:31:45 -0700, Stephen Boyd wrote :
> Remove useless ifdefs around function prototypes to silence the
> following sparse warnings when the configs aren't enabled.
>
> drivers/clk/at91/clk-h32mx.c:95:13: warning: symbol
> 'of_sama5d4_clk_h32mx_setup' was not declared. Should it be
> static?
> drivers/clk/at91/clk-utmi.c:159:13: warning: symbol
> 'of_at91sam9x5_clk_utmi_setup' was not declared. Should it be
> static?
>
> Plus, using __init in function prototypes doesn't do anything, so
> just drop it throughout this file.
>
The main drawback of that removal is that it destroys the alignment
throughout the header file :)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-06 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 19:31 [PATCH] clk: at91: Silence warnings and cleanup __init usage Stephen Boyd
2015-07-06 20:38 ` Alexandre Belloni [this message]
2015-07-06 21:37 ` Stephen Boyd
2015-07-07 17:17 ` Alexandre Belloni
2015-07-07 17:54 ` Boris Brezillon
2015-07-08 0:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706203811.GC3127@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.