All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Anshul Garg <aksgarg1989@gmail.com>
Cc: peterz@infradead.org, hpa@zytor.com,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/rt: Fix memory leak in alloc_rt_sched_group()
Date: Tue, 7 Jul 2015 08:45:42 +0200	[thread overview]
Message-ID: <20150707064542.GA7099@gmail.com> (raw)
In-Reply-To: <CA+HOOsiFpFX60L73en0oxTOwzJ50Q7dpNpUAEdOLmKszTHxzSw@mail.gmail.com>


* Anshul Garg <aksgarg1989@gmail.com> wrote:

> Dear linux community,
> 
> I think this patch" sched/rt: Fix memory leak in
> alloc_rt_sched_group()" with Commit-ID:
> ecdd6804b7c9e15fe8fc836ba0233d9912834e8b is not correct.
> 
> As it will create panic in case of kzalloc failure because of doingkfree twice.
> 
> As if alloc_rt_sched_group fails it will return zero then core.c will
> call free_sched_group in core.c
> which subsequently calls free_rt_sched_group .
> 
> In free_rt_sched_group memory is getting freed properly.
> 
> so it seems patch sent by me is not correct.
> 
> Please help to review patch once again as it might break some things.
> 
> Sorry for inconvenience.
> 
> Thanks
> Anshul Garg

Ok, I've removed this patch.

Thanks!

	Ingo

      reply	other threads:[~2015-07-07  6:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 19:29 [PATCH] Sched/rt:Fix memory leak in alloc_rt_sched_group Anshul Garg
2015-07-06 15:35 ` [tip:sched/core] sched/rt: Fix memory leak in alloc_rt_sched_group() tip-bot for Anshul Garg
2015-07-06 19:43   ` Anshul Garg
2015-07-07  6:45     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707064542.GA7099@gmail.com \
    --to=mingo@kernel.org \
    --cc=aksgarg1989@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.