From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "Alasdair G. Kergon" <agk@redhat.com>,
Edward Thornber <thornber@redhat.com>,
dm-devel@redhat.com, David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] dm: introduce dm_kvmalloc
Date: Tue, 7 Jul 2015 09:25:42 -0400 [thread overview]
Message-ID: <20150707132542.GA15860@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1507070848480.3944@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, Jul 07 2015 at 8:50am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Mon, 6 Jul 2015, Mike Snitzer wrote:
>
> > In general I like what you've done with this patchset _except_ I'm not
> > seeing why dm_kvmalloc() should be in DM at all. It should probably be
> > elevated to an kvmalloc() export from mm/util.c and include/linux/mm.h
> > along-side kvfree().
>
> If memory management maintainers agree to put it into mm core, it would be
> nice. If not, put it into device mapper.
Please rework your patches so that the mm changes are split out into
clean patch(es) at the start of the series.
Please cc Andrew and David on posting v2. Also, please chain the reply
so that the patchset is properly threaded.
prev parent reply other threads:[~2015-07-07 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 20:59 [PATCH 4/7] dm: introduce dm_kvmalloc Mikulas Patocka
2015-07-06 12:42 ` Vivek Goyal
2015-07-06 13:04 ` Mikulas Patocka
2015-07-06 13:07 ` Vivek Goyal
2015-07-07 12:52 ` Mikulas Patocka
2015-07-06 13:47 ` Mike Snitzer
2015-07-07 12:50 ` Mikulas Patocka
2015-07-07 13:25 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707132542.GA15860@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=rientjes@google.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.