From: Mark Brown <broonie@kernel.org>
To: yang.a.fang@intel.com
Cc: alsa-devel@alsa-project.org, srinivas.sripathi@intel.com,
praveen.k.jain@intel.com, lgirdwood@gmail.com,
denny.iriawan@intel.com, sathyanarayana.nujella@intel.com,
kevin.strasser@linux.intel.com, dgreid@chromium.org,
mika.westerberg@linux.intel.com
Subject: Re: [PATCH v2] ASoC: ts3a227e: do not report jack status when there is i2c read err
Date: Tue, 7 Jul 2015 14:47:22 +0100 [thread overview]
Message-ID: <20150707134722.GO2887@sirena.org.uk> (raw)
In-Reply-To: <1435793088-25971-1-git-send-email-yang.a.fang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]
On Wed, Jul 01, 2015 at 04:24:48PM -0700, yang.a.fang@intel.com wrote:
> after TI resumes. Also We should return if there is read err,the
> interrupt will come again since it is level triggered and we are not yet
> clear the interrupt.
> + ret = regmap_read(regmap, TS3A227E_REG_INTERRUPT, &int_reg);
> + if (ret) {
> + dev_err(dev, "failed to clear interrupt ret=%d\n", ret);
> + return IRQ_HANDLED;
> + }
This should return IRQ_NONE not IRQ_HANDLED - we didn't actually
successfully handle the interrupt. This lets the genirq code error
handling kick in if for some reason things are really broken and we just
can't interact with the device any more, it will eventually disable the
interrupt in that case.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-07-07 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 4:18 [PATCH] ASoC: ts3a227e: do not report jack status when there is i2c read err yang.a.fang
2015-07-01 17:12 ` Dylan Reid
2015-07-01 17:34 ` Yang Fang
2015-07-01 18:05 ` Mark Brown
2015-07-01 18:24 ` Fang, Yang A
2015-07-01 23:20 ` Fang, Yang A
2015-07-01 23:24 ` [PATCH v2] " yang.a.fang
2015-07-07 13:47 ` Mark Brown [this message]
2015-07-07 21:21 ` [PATCH v3] " yang.a.fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707134722.GO2887@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=denny.iriawan@intel.com \
--cc=dgreid@chromium.org \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=praveen.k.jain@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=srinivas.sripathi@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.