From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v10 4/5] crypto: Add Allwinner Security System crypto accelerator Date: Tue, 7 Jul 2015 16:01:39 +0200 Message-ID: <20150707140139.GF28632@lukather> References: <1436209848-16530-1-git-send-email-clabbe.montjoie@gmail.com> <1436209848-16530-5-git-send-email-clabbe.montjoie@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: LABBE Corentin Return-path: Content-Disposition: inline In-Reply-To: <1436209848-16530-5-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Corentin, On Mon, Jul 06, 2015 at 09:10:47PM +0200, LABBE Corentin wrote: > Add support for the Security System included in Allwinner SoC A20. > The Security System is a hardware cryptographic accelerator that support: > - MD5 and SHA1 hash algorithms > - AES block cipher in CBC/ECB mode with 128/196/256bits keys. > - DES and 3DES block cipher in CBC/ECB mode > > Signed-off-by: LABBE Corentin There's still a number of style issues. Make sure to run checkpatch with the --strict option, and fix everything that's reported. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --hK8Uo4Yp55NZU70L-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 7 Jul 2015 16:01:39 +0200 Subject: [PATCH v10 4/5] crypto: Add Allwinner Security System crypto accelerator In-Reply-To: <1436209848-16530-5-git-send-email-clabbe.montjoie@gmail.com> References: <1436209848-16530-1-git-send-email-clabbe.montjoie@gmail.com> <1436209848-16530-5-git-send-email-clabbe.montjoie@gmail.com> Message-ID: <20150707140139.GF28632@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Corentin, On Mon, Jul 06, 2015 at 09:10:47PM +0200, LABBE Corentin wrote: > Add support for the Security System included in Allwinner SoC A20. > The Security System is a hardware cryptographic accelerator that support: > - MD5 and SHA1 hash algorithms > - AES block cipher in CBC/ECB mode with 128/196/256bits keys. > - DES and 3DES block cipher in CBC/ECB mode > > Signed-off-by: LABBE Corentin There's still a number of style issues. Make sure to run checkpatch with the --strict option, and fix everything that's reported. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932202AbbGGOFc (ORCPT ); Tue, 7 Jul 2015 10:05:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50871 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757081AbbGGOFJ (ORCPT ); Tue, 7 Jul 2015 10:05:09 -0400 Date: Tue, 7 Jul 2015 16:01:39 +0200 From: Maxime Ripard To: LABBE Corentin Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, arnd@arndb.de, joe@perches.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v10 4/5] crypto: Add Allwinner Security System crypto accelerator Message-ID: <20150707140139.GF28632@lukather> References: <1436209848-16530-1-git-send-email-clabbe.montjoie@gmail.com> <1436209848-16530-5-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <1436209848-16530-5-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Corentin, On Mon, Jul 06, 2015 at 09:10:47PM +0200, LABBE Corentin wrote: > Add support for the Security System included in Allwinner SoC A20. > The Security System is a hardware cryptographic accelerator that support: > - MD5 and SHA1 hash algorithms > - AES block cipher in CBC/ECB mode with 128/196/256bits keys. > - DES and 3DES block cipher in CBC/ECB mode >=20 > Signed-off-by: LABBE Corentin There's still a number of style issues. Make sure to run checkpatch with the --strict option, and fix everything that's reported. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVm9vDAAoJEBx+YmzsjxAguOAP+gMPbft/rZyR9r3KmlVWvBqy 8JG3Dv1IbVUUDSMra1F/xofJZx4x1Bp6LvJpC8sPzUENU63dFjUcbCjbGGxSkgC3 dRZlB1AMG3PjOT1XcE3eF6J7yxnYph0ADopAMef7RICCo7VE8FnRDXw3B7k7nUos egN+wDEfbc/29ljoJbxt8ojOq3RBf5WTZCewsEhTO4EloQc0E8GbW3iUVnRPuJm8 QdrvRVt7x7yWYg6H0H/NXyNqk57jUEyV2QomiD5nw5t9Jdhncfc78lvZD2tquiLZ IrRd5XKIxpdBwcoaMQz7q8SUC2KFXsoAQf56VzqXkpi4hUfCC9+uHOd+ITu7gLQq HPptRLlLCSC9l44C3QsgYjru0MYdLTHXmT4bJp3gQ4kt1yUDSqk9ULg2ZlTDkE+n NjF+LAa1HEbsM8RRiajp2kEn31Z5uMrRRwCFJg7PH+LR891ajhiaJ4ninMc8U8Ad VQ7OVXvhjK0XVfC034xLFiCLCQC1z0gCrhVYw+gvQkkptoudP5MrIcjL554HwFz5 O6Id3eqLmFOVOZzRBePIqQa+cSczUTYX+amNyj2xwk5i7NCxtiv61iM0gHLCj14i 6RAbvPM9Mkj8oGuZK5FLGYOEQuZ2oS9LV/TVLcq6jGf1Djy0A57LIkGuEfyRHWSJ LYQYy92GXo8hNOuo/y5x =F4UA -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L--