From: Peter Zijlstra <peterz@infradead.org>
To: He Kuang <hekuang@huawei.com>
Cc: rostedt@goodmis.org, ast@plumgrid.com,
masami.hiramatsu.pt@hitachi.com, acme@kernel.org,
mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org,
wangnan0@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output
Date: Wed, 8 Jul 2015 00:47:40 +0200 [thread overview]
Message-ID: <20150707224740.GV3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1436269386-72037-2-git-send-email-hekuang@huawei.com>
On Tue, Jul 07, 2015 at 11:43:05AM +0000, He Kuang wrote:
> +FTRACE_ENTRY_REG(bpf, trace_bpf,
> +
> + TRACE_BPF,
> +
> + F_STRUCT(
> + __field(long, size)
I would suggest using either u32 or u64, not a variable size type like
long.
> + __array(u64, raw_data, TRACE_BPF_MAX_ENTRY)
> + ),
> +
> + F_printk("%ld: (%016llx, ...)", __entry->size, __entry->raw_data[0]),
> +
> + FILTER_OTHER,
> +
> + perf_ftrace_event_register
> +);
> --
> 1.8.5.2
>
next prev parent reply other threads:[~2015-07-07 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:43 [RFC PATCH v3 0/2] Make eBPF programs output data to perf event He Kuang
2015-07-07 11:43 ` [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output He Kuang
2015-07-07 22:47 ` Peter Zijlstra [this message]
2015-07-08 1:35 ` Alexei Starovoitov
2015-07-07 11:43 ` [RFC PATCH v3 2/2] bpf: Introduce function for outputing data to perf event He Kuang
2015-07-08 1:45 ` Alexei Starovoitov
2015-07-08 1:31 ` [RFC PATCH v3 0/2] Make eBPF programs output " Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707224740.GV3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.