All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 3.14 24/30] vfs: Ignore unlocked mounts in fs_fully_visible
Date: Wed,  8 Jul 2015 00:34:23 -0700	[thread overview]
Message-ID: <20150708073207.494487398@linuxfoundation.org> (raw)
In-Reply-To: <20150708073155.841723465@linuxfoundation.org>

3.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: "Eric W. Biederman" <ebiederm@xmission.com>

commit ceeb0e5d39fcdf4dca2c997bf225c7fc49200b37 upstream.

Limit the mounts fs_fully_visible considers to locked mounts.
Unlocked can always be unmounted so considering them adds hassle
but no security benefit.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/namespace.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -3031,11 +3031,15 @@ bool fs_fully_visible(struct file_system
 		if (mnt->mnt.mnt_root != mnt->mnt.mnt_sb->s_root)
 			continue;
 
-		/* This mount is not fully visible if there are any child mounts
-		 * that cover anything except for empty directories.
+		/* This mount is not fully visible if there are any
+		 * locked child mounts that cover anything except for
+		 * empty directories.
 		 */
 		list_for_each_entry(child, &mnt->mnt_mounts, mnt_child) {
 			struct inode *inode = child->mnt_mountpoint->d_inode;
+			/* Only worry about locked mounts */
+			if (!(mnt->mnt.mnt_flags & MNT_LOCKED))
+				continue;
 			if (!S_ISDIR(inode->i_mode))
 				goto next;
 			if (inode->i_nlink > 2)



  parent reply	other threads:[~2015-07-08  8:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08  7:33 [PATCH 3.14 00/30] 3.14.48-stable review Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 01/30] sparc: Use GFP_ATOMIC in ldc_alloc_exp_dring() as it can be called in softirq context Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 02/30] bridge: fix multicast router rlist endless loop Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 03/30] net: dont wait for order-3 page allocation Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 04/30] sctp: fix ASCONF list handling Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 05/30] bridge: fix br_stp_set_bridge_priority race conditions Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 06/30] packet: read num_members once in packet_rcv_fanout() Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 07/30] packet: avoid out of bounds read in round robin fanout Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 08/30] neigh: do not modify unlinked entries Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 09/30] tcp: Do not call tcp_fastopen_reset_cipher from interrupt context Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 10/30] net: phy: fix phy link up when limiting speed via device tree Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 11/30] sctp: Fix race between OOTB responce and route removal Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 12/30] crypto: talitos - avoid memleak in talitos_alg_alloc() Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 13/30] Revert "crypto: talitos - convert to use be16_add_cpu()" Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 14/30] iommu/amd: Handle large pages correctly in free_pagetable Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 15/30] intel_pstate: set BYT MSR with wrmsrl_on_cpu() Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 16/30] arm: KVM: force execution of HCPTR access on VM exit Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 17/30] powerpc/perf: Fix book3s kernel to userspace backtraces Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 18/30] x86/PCI: Use host bridge _CRS info on systems with >32 bit addressing Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 19/30] x86/PCI: Use host bridge _CRS info on Foxconn K8M890-8237A Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 20/30] MIPS: Fix KVM guest fixmap address Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 22/30] fs: Fix S_NOSEC handling Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 23/30] vfs: Remove incorrect debugging WARN in prepend_path Greg Kroah-Hartman
2015-07-08  7:34 ` Greg Kroah-Hartman [this message]
2015-07-08  7:34 ` [PATCH 3.14 25/30] arm/arm64: KVM: Require in-kernel vgic for the arch timers Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 26/30] arm64: KVM: Fix TLB invalidation by IPA/VMID Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 27/30] arm64: KVM: Fix HCR setting for 32bit guests Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 28/30] arm64: KVM: Do not use pgd_index to index stage-2 pgd Greg Kroah-Hartman
2015-07-08  7:34 ` [PATCH 3.14 30/30] x86/iosf: Add Kconfig prompt for IOSF_MBI selection Greg Kroah-Hartman
2015-07-08 14:07 ` [PATCH 3.14 00/30] 3.14.48-stable review Guenter Roeck
2015-07-08 14:57 ` Sudip Mukherjee
2015-07-08 16:33 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708073207.494487398@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.