All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Josh Cartwright <joshc@ni.com>
Cc: Christopher Hall <christopher.s.hall@intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	john.ronciak@intel.com, john.stultz@linaro.org,
	tglx@linutronix.de
Subject: Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:
Date: Wed, 8 Jul 2015 13:54:34 +0200	[thread overview]
Message-ID: <20150708115434.GA17012@localhost.localdomain> (raw)
In-Reply-To: <20150706204458.GE25028@jcartwri.amer.corp.natinst.com>

On Mon, Jul 06, 2015 at 03:44:58PM -0500, Josh Cartwright wrote:
> It's difficult to make too many judgements without seeing how a driver
> might implement this; is there another patchset that shows how a driver
> implements this?

The interface is certainly clear enough to me.  The details of
obtaining a cross time stamp from the hardware will remain hidden
behind the interface in any case.

> > -	int rsv[14];   /* Reserved for future use. */
> > +	/* Whether the clock supports precise system-device cross timestamps */
> > +	int precise_timestamping;
> 
> Perhaps now is a good time to add an unsigned int 'flags' member instead,
> and start allocating bits.

Considering the rate of growth for the PHC stuff, I am not worried
about spending a whole 'int' on this.

Thanks,
Richard



  reply	other threads:[~2015-07-08 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03  1:14 [PATCH v2 0/1] Add PTP cross-timestamp to the PTP driver interface Christopher Hall
2015-07-03  1:14 ` [PATCH v2 1/1] Added additional callback to ptp_clock_info: Christopher Hall
2015-07-03  7:00   ` Richard Cochran
2015-07-06 20:44   ` Josh Cartwright
2015-07-08 11:54     ` Richard Cochran [this message]
2015-07-08 12:17       ` Josh Cartwright
2015-07-09 14:53         ` Richard Cochran
2015-07-03  6:49 ` [PATCH v2 0/1] Add PTP cross-timestamp to the PTP driver interface Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708115434.GA17012@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=christopher.s.hall@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=john.stultz@linaro.org \
    --cc=joshc@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.