All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] usb: gadget: bcm_udc_otg files
Date: Wed, 8 Jul 2015 16:35:36 +0200	[thread overview]
Message-ID: <201507081635.37059.marex@denx.de> (raw)
In-Reply-To: <20150708162214.538a9745@amdc2363>

On Wednesday, July 08, 2015 at 04:22:14 PM, Lukasz Majewski wrote:
> Hi Steve,

Hi!

> > >> b/drivers/usb/gadget/bcm_udc_otg.h new file mode 100644
> > >> index 0000000..81a1fc0
> > >> --- /dev/null
> > >> +++ b/drivers/usb/gadget/bcm_udc_otg.h
> > >> @@ -0,0 +1,17 @@
> > >> +/*
> > >> + * Copyright 2015 Broadcom Corporation.
> > > 
> > > --> Please also add the name of the code author.
> > 
> > this is not standard practice at Broadcom....
> > and it seems that at least five (5) people have contributed to the
> > code in this commit....
> > What would you suggest? The most recent author, or ???
> 
> I will not push you to add names if it is not mandatory in your company.
> 
> I just wanted to stress here that putting ones name is some kind of
> reward when working with community.

And it's also much easier to point fingers if something goes wrong :-)
(and contact the author, but that's in git log too, so whatever)

[...]

Best regards,
Marek Vasut

  reply	other threads:[~2015-07-08 14:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 19:49 [U-Boot] [PATCH v2 0/4] This series implements fastboot on the "bcm28155_ap" boards Steve Rae
2015-07-06 19:49 ` [U-Boot] [PATCH v2 1/4] g_dnl: add missing declaration Steve Rae
2015-07-07 13:19   ` Lukasz Majewski
2015-07-06 19:49 ` [U-Boot] [PATCH v2 2/4] usb: s3c-otg: support 8-bit interface Steve Rae
2015-07-07 13:27   ` Lukasz Majewski
2015-07-07 19:43     ` Steve Rae
2015-07-08 14:14       ` Lukasz Majewski
2015-07-06 19:49 ` [U-Boot] [PATCH v2 3/4] usb: gadget: bcm_udc_otg files Steve Rae
2015-07-07 13:33   ` Lukasz Majewski
2015-07-07 20:26     ` Steve Rae
2015-07-08 14:22       ` Lukasz Majewski
2015-07-08 14:35         ` Marek Vasut [this message]
2015-07-06 19:49 ` [U-Boot] [PATCH v2 4/4] implement Fastboot via USB OTG on bcm28155_ap boards Steve Rae
2015-07-07 13:39   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201507081635.37059.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.