From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH] x86: correct socket_cpumask allocation for
	AP
Date: Thu, 9 Jul 2015 09:47:32 +0800
Message-ID: <20150709014732.GF3333@pengc-linux.bj.intel.com>
References: <1436348218-29172-1-git-send-email-chao.p.peng@linux.intel.com>
	<559D35FD020000780008E354@mail.emea.novell.com>
	<1436368264.22672.219.camel@citrix.com>
	<559D602C020000780008E585@mail.emea.novell.com>
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <559D602C020000780008E585@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, Dario Faggioli <dario.faggioli@citrix.com>, keir@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, Jul 08, 2015 at 04:38:52PM +0100, Jan Beulich wrote:
> >>> On 08.07.15 at 17:11, <dario.faggioli@citrix.com> wrote:
> > On Wed, 2015-07-08 at 13:38 +0100, Jan Beulich wrote:
> >> >>> On 08.07.15 at 11:36, <chao.p.peng@linux.intel.com> wrote:
> >> > @@ -84,11 +85,21 @@ void *stack_base[NR_CPUS];
> >> >  static void smp_store_cpu_info(int id)
> >> >  {
> >> >      struct cpuinfo_x86 *c = cpu_data + id;
> >> > +    unsigned int socket;
> >> >  
> >> >      *c = boot_cpu_data;
> >> >      if ( id != 0 )
> >> > +    {
> >> >          identify_cpu(c);
> >> >  
> >> > +        socket = cpu_to_socket(id);
> >> > +        if ( !socket_cpumask[socket] )
> >> > +        {
> >> > +            socket_cpumask[socket] = secondary_socket_cpumask;
> >> > +            secondary_socket_cpumask = NULL;
> >> 
> >> I don't think this will build with small enough NR_CPUS.
> >>
> > And it *does* *not* fix the issue on my box.
> 
> I.e. bad analysis (albeit it seemed correct to me) _and_ new code
> not tested.

I did test it on my 2-sockets box, perhaps not covered all the cases.

> Chao, one more try, or we'll have to revert the whole
> series (closing the window for it for 4.6).

I honor this chance and certainly will try my best.

Thanks Jan.

Chao