On Wed, Jul 08, 2015 at 07:38:33PM +0100, Mark Brown wrote: > On Fri, Jul 03, 2015 at 04:04:04PM +0530, Vinod Koul wrote: > > From: "Subhransu S. Prusty" > > > > We will add SKL platform data. So organizing common and platform > > specific data helps. > > > struct sst_dsp { > > > > + /* Shared for all platforms */ > > + > > /* runtime */ > > struct sst_dsp_device *sst_dev; > > spinlock_t spinlock; /* IPC locking */ > > @@ -268,10 +270,6 @@ struct sst_dsp { > > int irq; > > u32 id; > > > > - /* list of free and used ADSP memory blocks */ > > - struct list_head used_block_list; > > - struct list_head free_block_list; > > - > > Perhaps a union might start to make sense at some point? Initially we did start with a union but Liam didn't like another indirection. Anyway since not a bunch a members are getting added here, this should be okay Liam you want to add here... -- ~Vinod