From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: dapm: Fix kcontrol widget name memory management
Date: Thu, 9 Jul 2015 09:06:12 +0100 [thread overview]
Message-ID: <20150709080612.GL16517@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1436385599-12403-1-git-send-email-lars@metafoo.de>
On Wed, Jul 08, 2015 at 09:59:59PM +0200, Lars-Peter Clausen wrote:
> The name field of the widget template is only used inside
> snd_soc_dapm_new_control_unlocked() which allocates a copy for the actual
> widget. This means we need to free the name allocated for the template in
> dapm_kcontrol_data_alloc() and not the name of the actual widget in
> dapm_kcontrol_free(). Otherwise we get a double free on the widget name and
> a memory leak on the template name.
>
> Fixes: 773da9b358bf ("ASoC: dapm: Append "Autodisable" to autodisable widget names")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Oops, thanks for fixing that up.
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
prev parent reply other threads:[~2015-07-09 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 19:59 [PATCH] ASoC: dapm: Fix kcontrol widget name memory management Lars-Peter Clausen
2015-07-08 21:17 ` Applied "ASoC: dapm: Fix kcontrol widget name memory management" to the asoc tree Mark Brown
2015-07-09 8:06 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709080612.GL16517@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.