All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Oliver Neukum <oliver@neukum.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdc-acm: Destroy acm_minors IDR on module exit
Date: Thu, 9 Jul 2015 10:57:06 +0200	[thread overview]
Message-ID: <20150709085706.GB18161@localhost> (raw)
In-Reply-To: <1436369142-31303-1-git-send-email-jthumshirn@suse.de>

On Wed, Jul 08, 2015 at 05:25:42PM +0200, Johannes Thumshirn wrote:
> Destroy acm_minors IDR on module exit, reclaiming the allocated memory.

> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>  drivers/usb/class/cdc-acm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 519a77b..b30e742 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1944,6 +1944,7 @@ static void __exit acm_exit(void)
>  	usb_deregister(&acm_driver);
>  	tty_unregister_driver(acm_tty_driver);
>  	put_tty_driver(acm_tty_driver);
> +	idr_destroy(&acm_minors);
>  }
>  
>  module_init(acm_init);

Acked-by: Johan Hovold <johan@kernel.org>

No stable-tag needed as idr wasn't used before 4.2.

Thanks,
Johan

  reply	other threads:[~2015-07-09  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 15:25 [PATCH] cdc-acm: Destroy acm_minors IDR on module exit Johannes Thumshirn
2015-07-09  8:57 ` Johan Hovold [this message]
2015-07-09 11:05 ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150709085706.GB18161@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.