All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Vince Weaver <vincent.weaver@maine.edu>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	Borislav Petkov <bp@suse.de>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [RFC PATCH] perf: Provide status of known PMUs
Date: Thu, 9 Jul 2015 13:44:33 +0200	[thread overview]
Message-ID: <20150709114433.GR19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <559E3F36.5020900@intel.com>

On Thu, Jul 09, 2015 at 12:30:30PM +0300, Adrian Hunter wrote:
> On 09/07/15 11:50, Peter Zijlstra wrote:

> > Can we limit it to PMUs for which we've (attempted to) load the drivers?
> > That would obviously make a few of your status bits redundant, but then
> > you've not explained why we're interested in it.

> >> 	Driver not in kernel config
> >> 	Not supported by kernel
> >> 	Wrong architecture
> > 
> > These will be hard, for if we don't load the driver we don't 'know' of
> > them.
> 
> Are they that hard?

Because if we limit known to be what we're tried to probe, you simply do
not know about PMUs for the wrong arch or not build by the kernel etc.

> static struct known_pmu known_pmus[] = {
> 	KNOWN_PMU("intel_pt", "Intel", PERF_PMU_STATUS_ARCH_X86),
> 	KNOWN_PMU("intel_bts", "Intel", PERF_PMU_STATUS_ARCH_X86),
> 	KNOWN_PMU(NULL, NULL, 0),
> };

So I really don't like this hard-coded table much, that's just going to
be a pain to maintain.

      reply	other threads:[~2015-07-09 11:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09  7:48 [RFC PATCH] perf: Provide status of known PMUs Adrian Hunter
2015-07-09  8:10 ` Ingo Molnar
2015-07-09  8:44   ` Adrian Hunter
2015-07-09  8:50 ` Peter Zijlstra
2015-07-09  9:26   ` Ingo Molnar
2015-07-09 11:59     ` Peter Zijlstra
2015-07-09 12:32       ` Ingo Molnar
2015-07-09 12:42         ` Peter Zijlstra
2015-07-09 14:47           ` Arnaldo Carvalho de Melo
2015-07-10  8:35           ` Ingo Molnar
2015-07-10 18:59             ` Stephane Eranian
2015-07-09  9:30   ` Adrian Hunter
2015-07-09 11:44     ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150709114433.GR19282@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@suse.de \
    --cc=eranian@google.com \
    --cc=hpa@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.