From: Chao Peng <chao.p.peng@linux.intel.com>
To: Ian Campbell <ian.campbell@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/xl: Fix build error following c/s f52fbcf7
Date: Thu, 9 Jul 2015 21:31:04 +0800 [thread overview]
Message-ID: <20150709133103.GH3333@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <1436438863.23508.107.camel@citrix.com>
On Thu, Jul 09, 2015 at 11:47:43AM +0100, Ian Campbell wrote:
> On Thu, 2015-07-09 at 11:36 +0100, Andrew Cooper wrote:
> > CentOS7 complains that 'ret' might be unused, and indeed this is the case for
> > `xl psr-hwinfo --cat`.
> >
> > The logic for selecting which information to print was rather awkward.
> > Introduce a new 'all' which default to true, and is cleared if specific
> > options are selected. This allows for a far more clear logic when choosing
> > whether to print information or not.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
>
> I'll wait a bit before applying to give Chao a chance to have a look.
Thanks and I verified it successfully on my psr-enabled box.
Chao
>
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Chao Peng <chao.p.peng@linux.intel.com>
> >
next prev parent reply other threads:[~2015-07-09 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:36 [PATCH] tools/xl: Fix build error following c/s f52fbcf7 Andrew Cooper
2015-07-09 10:47 ` Ian Campbell
2015-07-09 13:31 ` Chao Peng [this message]
2015-07-09 14:20 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709133103.GH3333@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.