Re: [Qemu-devel] [PATCH for 2.4 1/2] tcg/mips: Fix build error from merged memop+mmu_idx parameter

[Aurelien Jarno <aurelien@aurel32.net>]

On 2015-07-09 10:17, James Hogan wrote:
> Commit 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to
> softmmu routines") caused the following build errors when building TCG
> for MIPS:
> 
> In file included from tcg/tcg.c:258:0:
> tcg/mips/tcg-target.c In function ‘tcg_out_qemu_ld_slow_path’:
> tcg/mips/tcg-target.c:1015:22: error: ‘lb’ undeclared (first use in this function)
> tcg/mips/tcg-target.c In function ‘tcg_out_qemu_st_slow_path’:
> tcg/mips/tcg-target.c:1058:22: error: ‘lb’ undeclared (first use in this function)
> 
> It looks like lb was meant to refer to the TCGLabelQemuLdst *l
> parameter, so fix both references to lb to refer to just l.
> 
> Fixes: 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to softmmu routines")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
>  tcg/mips/tcg-target.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

I was planning to test various hosts after the rc0 release, but it seems
you have been faster. Unfortunately we have more regressions, I am going
to send some more mails.

I am fine if it can be merged directly.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net