From: Aurelien Jarno <aurelien@aurel32.net>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] qcow crypto changes crash on migration (was: [PULL 10/12] block: convert qcow/qcow2 to use generic cipher API)
Date: Thu, 9 Jul 2015 16:51:39 +0200 [thread overview]
Message-ID: <20150709145139.GB21010@aurel32.net> (raw)
In-Reply-To: <559E528D.60500@de.ibm.com>
On 2015-07-09 12:53, Christian Borntraeger wrote:
> Forgot some CCs (patch author and migration folks)
>
>
> Am 09.07.2015 um 12:17 schrieb Christian Borntraeger:
> > Am 07.07.2015 um 16:12 schrieb Paolo Bonzini:
> >> From: "Daniel P. Berrange" <berrange@redhat.com>
> >>
> >> Switch the qcow/qcow2 block driver over to use the generic cipher
> >> API, this allows it to use the pluggable AES implementations,
> >> instead of being hardcoded to use QEMU's built-in impl.
> >>
> >> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> >> Message-Id: <1435770638-25715-10-git-send-email-berrange@redhat.com>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > For whatever reason this breaks migration(or virsh restore)
> > from guests that were created with an older version of QEMU.
> >
> >
> >
> > Thread 1 (Thread 0x3fffb856bd0 (LWP 32226)):
> > #0 0x0000000080354a54 in qcrypto_cipher_free (cipher=0x0) at /home/cborntra/REPOS/qemu/crypto/cipher-builtin.c:357
> > #1 0x00000000802ca912 in qcow2_close (bs=0x80a0cea0) at /home/cborntra/REPOS/qemu/block/qcow2.c:1477
> > #2 0x00000000802caa32 in qcow2_invalidate_cache (bs=0x80a0cea0, errp=0x81a3fc58) at /home/cborntra/REPOS/qemu/block/qcow2.c:1509
> > #3 0x000000008029bac0 in bdrv_invalidate_cache (bs=0x80a0cea0, errp=0x81a3fd08) at /home/cborntra/REPOS/qemu/block.c:3135
> > #4 0x000000008029bbe6 in bdrv_invalidate_cache_all (errp=0x81a3fdd0) at /home/cborntra/REPOS/qemu/block.c:3160
> > #5 0x000000008021de50 in process_incoming_migration_co (opaque=0x80acaae0) at /home/cborntra/REPOS/qemu/migration/migration.c:160
> > #6 0x00000000802ab96a in coroutine_trampoline (i0=0, i1=-2137149984) at /home/cborntra/REPOS/qemu/coroutine-ucontext.c:80
> > #7 0x000003fffc463ca2 in __makecontext_ret () from /lib64/libc.so.6
> > Backtrace stopped: previous frame identical to this frame (corrupt stack?)
This is the same kind of backtrace I got on a MIPS host (see my other
mail). The reason is that a NULL pointer is dereferenced before testing
it is non NULL in qcrypto_cipher_free.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2015-07-09 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:12 [Qemu-devel] [PULL v2 00/12] Final changes for 2.4-rc0 Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 01/12] vl: move rom_load_all after machine init done Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 02/12] crypto: introduce new module for computing hash digests Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 03/12] crypto: move built-in AES implementation into crypto/ Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 04/12] crypto: move built-in D3DES " Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 05/12] crypto: introduce generic cipher API & built-in implementation Paolo Bonzini
2015-07-09 14:09 ` Aurelien Jarno
2015-07-07 14:12 ` [Qemu-devel] [PULL 06/12] crypto: add a gcrypt cipher implementation Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 07/12] crypto: add a nettle " Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 08/12] block: convert quorum blockdrv to use crypto APIs Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 09/12] ui: convert VNC websockets " Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 10/12] block: convert qcow/qcow2 to use generic cipher API Paolo Bonzini
2015-07-09 10:17 ` Christian Borntraeger
2015-07-09 10:53 ` [Qemu-devel] qcow crypto changes crash on migration (was: [PULL 10/12] block: convert qcow/qcow2 to use generic cipher API) Christian Borntraeger
2015-07-09 11:20 ` [Qemu-devel] qcow crypto changes crash on migration Christian Borntraeger
2015-07-09 14:51 ` Aurelien Jarno [this message]
2015-07-07 14:12 ` [Qemu-devel] [PULL 11/12] ui: convert VNC to use generic cipher API Paolo Bonzini
2015-07-07 14:12 ` [Qemu-devel] [PULL 12/12] ossaudio: fix memory leak Paolo Bonzini
2015-07-08 10:48 ` [Qemu-devel] [PULL v2 00/12] Final changes for 2.4-rc0 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709145139.GB21010@aurel32.net \
--to=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.