From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ixgbe: do not include CRC in Tx byte count
Date: Thu, 9 Jul 2015 16:03:37 -0700
Message-ID: <20150709160337.3ba72cae@urahara>
References: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com>
 <1556408.e2XOMCRvgs@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com
 [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id DB11C5A96
 for <dev@dpdk.org>; Fri, 10 Jul 2015 01:03:28 +0200 (CEST)
Received: by pdjr16 with SMTP id r16so11514486pdj.3
 for <dev@dpdk.org>; Thu, 09 Jul 2015 16:03:28 -0700 (PDT)
In-Reply-To: <1556408.e2XOMCRvgs@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 01 Apr 2015 09:45:02 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-03-24 23:54, Ananyev, Konstantin:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > On Mon, 23 Mar 2015 16:45:44 +0000
> > > "Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote:
> > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of stephen@networkplumber.org
> > > > > From: Stephen Hemminger <shemming@brocade.com>
> > > > >
> > > > > The ixgbe driver was including CRC in the transmit packet byte
> > > > > count, but not for packets received.
> > > > > This was notice when forwarding and
> > > > > the number of bytes received was greater than the number of bytes transmitted
> > > > > for the same number of packets. Make the driver behave like other
> > > > > virtual devices and not include CRC in byte count. Use the same queue
> > > > > counters already computed and used for Rx.
> > > >
> > > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure().
> > > > If hw_stip_crc==1, then, yes CRC bytes are not included into  QBRC value.
> > > > I If hw_stip_crc==0, then CRC bytes are included into QBRC.
> > > 
> > > That is an additional bug!
> > >   * CRC should never be included in the byte count.
> > >     This is not how Linux or other drivers report byte count.
> > 
> > I don't have any strong opinion here...
> > For me any method (with or without CRC) of counting bytes are ok, as long as this method is identical across all PMDs we support.
> > Which makes we wonder, what approach other PMDs use? 
> > 
> > > 
> > >   * the byte count must be symmetrical Rx == Tx
> > > 
> > > The Brocade router always set strip_crc to 1. So did not see the additional bug
> > > of CRC being included in byte count.
> > 
> > Are you going to submit v2, to make Rx==Tx for both cases?
> 
> Any conclusion?
> Without update, this patch is going to be dropped.

My conclusion was that CRC should never be in byte count regardless of
configuration because that is what everyone (except CISCO) expects.

My patch did that.