From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] uprobes: fix the waitqueue_active() check in xol_free_insn_slot()
Date: Thu, 9 Jul 2015 23:44:51 +0200 [thread overview]
Message-ID: <20150709214451.GA15021@redhat.com> (raw)
In-Reply-To: <20150709214431.GA14997@redhat.com>
The xol_free_insn_slot()->waitqueue_active() check is buggy. We need
mb() after we set the conditon for wait_event(), or xol_take_insn_slot()
can miss the wakeup.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/events/uprobes.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 6a9c5e0..9a4f9df 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1336,6 +1336,7 @@ static void xol_free_insn_slot(struct task_struct *tsk)
clear_bit(slot_nr, area->bitmap);
atomic_dec(&area->slot_count);
+ smp_mb__after_atomic(); /* pairs with prepare_to_wait() */
if (waitqueue_active(&area->wq))
wake_up(&area->wq);
--
1.5.5.1
next prev parent reply other threads:[~2015-07-09 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 21:44 uprobes: minor fixes + name the xol vma Oleg Nesterov
2015-07-09 21:44 ` [PATCH 1/3] uprobes: fix the usage of install_special_mapping() Oleg Nesterov
2015-07-09 21:49 ` Andy Lutomirski
2015-07-09 22:02 ` Oleg Nesterov
2015-07-09 22:12 ` Andy Lutomirski
2015-07-09 21:44 ` [PATCH 2/3] uprobes: use vm_special_mapping to name the xol vma Oleg Nesterov
2015-07-09 21:50 ` Andy Lutomirski
2015-07-09 22:03 ` Oleg Nesterov
2015-07-09 21:44 ` Oleg Nesterov [this message]
2015-07-09 22:25 ` [PATCH v2 0/3] uprobes: minor fixes + " Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 1/3] uprobes: fix the usage of install_special_mapping() Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 2/3] uprobes: use vm_special_mapping to name the xol vma Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 3/3] uprobes: fix the waitqueue_active() check in xol_free_insn_slot() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709214451.GA15021@redhat.com \
--to=oleg@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.