From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754556AbbGIWFU (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jul 2015 18:05:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46023 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754161AbbGIWFP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jul 2015 18:05:15 -0400
Date: Fri, 10 Jul 2015 00:03:41 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] uprobes: use vm_special_mapping to name the xol vma
Message-ID: <20150709220341.GC15485@redhat.com>
References: <20150709214431.GA14997@redhat.com> <20150709214449.GA15018@redhat.com> <CALCETrWoFdim09Z6-9UNj3JJHYd-3wnBq-WaJ9m=5DV20T-Ovw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWoFdim09Z6-9UNj3JJHYd-3wnBq-WaJ9m=5DV20T-Ovw@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/09, Andy Lutomirski wrote:
>
> On Thu, Jul 9, 2015 at 2:44 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > Change xol_add_vma() to use _install_special_mapping(), this way
> > we can name the vma installed by uprobes. Currently it looks like
> > private anonymous mapping, this is confusing and complicates the
> > debugging. With this change /proc/$pid/maps reports "[uprobes]".
>
> I think this will cause core dumps to include it as a side effect.  Is
> that okay?

Yes, I even mentioned this in 0/3... I'll move thhis note into the
changelog in v2.

Thanks!

Oleg.