From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <arapov@gmail.com>,
David Long <dave.long@linaro.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Jan Willeke <willeke@de.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>,
Mark Wielaard <mjw@redhat.com>,
Pratyush Anand <panand@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/11] uprobes/x86: Reimplement arch_uretprobe_is_alive()
Date: Fri, 10 Jul 2015 17:23:32 +0530 [thread overview]
Message-ID: <20150710115332.GG26095@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150707012258.GA7533@redhat.com>
* Oleg Nesterov <oleg@redhat.com> [2015-07-07 03:22:58]:
> Add the x86-specific version of arch_uretprobe_is_alive() helper.
> It returns true if the stack frame mangled by prepare_uretprobe()
> is still on stack. So if it returns false, we know that the probed
> function has already returned.
>
> We add the new return_instance->stack member and change the generic
> code to initialize it in prepare_uretprobe, but it should be equally
> useful for other architectures.
>
> TODO: this assumes that the probed application can't use multiple
> stacks (say sigaltstack). We will try to improve this logic later.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Looks good to me.
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2015-07-10 11:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 1:22 [PATCH v2 00/11] uprobes: longjmp fixes Oleg Nesterov
2015-07-07 1:22 ` [PATCH v2 01/11] uprobes: Introduce get_uprobe() Oleg Nesterov
2015-07-07 12:44 ` Anton Arapov
2015-07-07 1:22 ` [PATCH v2 02/11] uprobes: Introduce free_ret_instance() Oleg Nesterov
2015-07-07 12:46 ` Anton Arapov
2015-07-07 1:22 ` [PATCH v2 03/11] uprobes: Send SIGILL if handle_trampoline() fails Oleg Nesterov
2015-07-07 12:51 ` Anton Arapov
2015-07-07 1:22 ` [PATCH v2 04/11] uprobes: Change prepare_uretprobe() to use uprobe_warn() Oleg Nesterov
2015-07-07 12:52 ` Anton Arapov
2015-07-07 1:22 ` [PATCH v2 05/11] uprobes: Change handle_trampoline() to find the next chain beforehand Oleg Nesterov
2015-07-07 12:54 ` Anton Arapov
2015-07-07 1:22 ` [PATCH v2 06/11] uprobes: Export struct return_instance, introduce arch_uretprobe_is_alive() Oleg Nesterov
2015-07-07 12:58 ` Anton Arapov
2015-07-10 11:52 ` Srikar Dronamraju
2015-07-07 1:22 ` [PATCH v2 07/11] uprobes/x86: Reimplement arch_uretprobe_is_alive() Oleg Nesterov
2015-07-07 13:02 ` Anton Arapov
2015-07-10 11:53 ` Srikar Dronamraju [this message]
2015-07-07 1:23 ` [PATCH v2 08/11] uprobes: Change handle_trampoline() to flush the frames invalidated by longjmp() Oleg Nesterov
2015-07-07 13:05 ` Anton Arapov
2015-07-10 11:55 ` Srikar Dronamraju
2015-07-07 1:23 ` [PATCH v2 09/11] uprobes: Change prepare_uretprobe() to (try to) flush the dead frames Oleg Nesterov
2015-07-07 13:07 ` Anton Arapov
2015-07-10 11:57 ` Srikar Dronamraju
2015-07-07 1:23 ` [PATCH v2 10/11] uprobes: Add the "enum rp_check ctx" arg to arch_uretprobe_is_alive() Oleg Nesterov
2015-07-07 13:08 ` Anton Arapov
2015-07-10 12:06 ` Srikar Dronamraju
2015-07-07 1:23 ` [PATCH v2 11/11] uprobes/x86: Make arch_uretprobe_is_alive(RP_CHECK_CALL) more clever Oleg Nesterov
2015-07-07 13:11 ` Anton Arapov
2015-07-10 12:07 ` Srikar Dronamraju
2015-07-10 12:01 ` [PATCH v2 00/11] uprobes: longjmp fixes Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710115332.GG26095@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=arapov@gmail.com \
--cc=dave.long@linaro.org \
--cc=dvlasenk@redhat.com \
--cc=fche@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjw@redhat.com \
--cc=oleg@redhat.com \
--cc=panand@redhat.com \
--cc=willeke@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.