All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Waiman Long <Waiman.Long@hp.com>
Subject: Re: [BUG][tip/master] kernel panic while locking selftest at qspinlock_paravirt.h:137!
Date: Fri, 10 Jul 2015 15:57:46 +0200	[thread overview]
Message-ID: <20150710135746.GA13461@gmail.com> (raw)
In-Reply-To: <20150710130028.GI19282@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Jul 10, 2015 at 08:32:46PM +0900, Masami Hiramatsu wrote:
> 
> >                     double unlock:
> > ------------[ cut here ]------------
> > kernel BUG at /home/mhiramat/ksrc/linux-3/kernel/locking/qspinlock_paravirt.h:137!
> 
> > Call Trace:
> >  [<ffffffff81114a59>] __raw_callee_save___pv_queued_spin_unlock+0x11/0x1e
> >  [<ffffffff81117133>] ? do_raw_spin_unlock+0xfa/0x10c
> >  [<ffffffff817cd3f7>] _raw_spin_unlock+0x44/0x64
> >  [<ffffffff814603ee>] double_unlock_spin+0x3d/0x46
> 
> Cute, but somewhat expected. A double unlock really is a BUG and the PV
> spinlock code cannot deal with it.
> 
> Do we want to make double unlock non-fatal unconditionally?

No, just don't BUG() out, don't crash the system - generate a warning?

Thanks,

	Ingo

  reply	other threads:[~2015-07-10 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 11:32 [BUG][tip/master] kernel panic while locking selftest at qspinlock_paravirt.h:137! Masami Hiramatsu
2015-07-10 13:00 ` Peter Zijlstra
2015-07-10 13:57   ` Ingo Molnar [this message]
2015-07-10 14:28     ` Peter Zijlstra
2015-07-11  0:32       ` Masami Hiramatsu
2015-07-11  1:27         ` Waiman Long
2015-07-11  5:05           ` Masami Hiramatsu
2015-07-12  3:09             ` Waiman Long
2015-07-11 10:22           ` Peter Zijlstra
2015-07-11 10:27       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710135746.GA13461@gmail.com \
    --to=mingo@kernel.org \
    --cc=Waiman.Long@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.