From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Hugh Dickins <hughd@google.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] special_mapping_fault() is broken
Date: Fri, 10 Jul 2015 20:08:14 +0300 [thread overview]
Message-ID: <20150710170814.GA910@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150710165121.GA10341@redhat.com>
On Fri, Jul 10, 2015 at 06:51:21PM +0200, Oleg Nesterov wrote:
> Hello,
>
> special_mapping_fault() is absolutely broken. It seems it was always
> wrong, but this didn't matter until vdso/vvar started to use more than
> one page.
>
> The patches are the same, just 1/3 was re-diffed on top of the recent
> 6b7339f4c31ad "mm: avoid setting up anonymous pages into file mapping"
> from Kirill.
>
> And after this change vma_is_anonymous() becomes really trivial, it
> simply checks vm_ops == NULL. However, I do think the helper makes
> sense. There are a lot of ->vm_ops != NULL checks, the helper makes
> the caller's code more understandable (self-documented) and this is
> more grep-friendly.
For all three:
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2015-07-10 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 16:51 [PATCH v2 0/3] special_mapping_fault() is broken Oleg Nesterov
2015-07-10 16:51 ` [PATCH v2 1/3] mm: introduce vma_is_anonymous(vma) helper Oleg Nesterov
2015-07-10 16:51 ` [PATCH v2 2/3] mmap: fix the usage of ->vm_pgoff in special_mapping paths Oleg Nesterov
2015-07-10 16:51 ` [PATCH v2 3/3] mremap: fix the wrong !vma->vm_file check in copy_vma() Oleg Nesterov
2015-07-10 17:08 ` Kirill A. Shutemov [this message]
2015-07-10 18:20 ` [PATCH v2 0/3] special_mapping_fault() is broken Davidlohr Bueso
2015-07-10 21:52 ` Andrew Morton
2015-07-11 23:43 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710170814.GA910@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.