From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Dave Jones <davej@codemonkey.org.uk>,
x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: CONFIG_DEBUG_VIRTUAL instant reboot.
Date: Sat, 11 Jul 2015 11:37:09 +0200 [thread overview]
Message-ID: <20150711093709.GA27975@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1507111009530.17353@nanos>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 10 Jul 2015, Dave Jones wrote:
> > I bought a Haswell Xeon E3-1225 v3 box, and found that
> > my self-built kernel would instantly reboot the machine once
> > grub had loaded it.
> >
> > Through trial and error I found the following options matter..
> >
> > if I _enable_ DEBUG_PAGEALLOC, it boots fine.
> > disabling it again, instant death.
> >
> > further narrowing down revealed that if I have DEBUG_PAGEALLOC off,
> > I also _must_ also have CONFIG_DEBUG_VIRTUAL turned off.
> > With both disabled, it also boots fine.
> >
> > I tried earlyprintk, but this happens so soon I don't think
> > we're even at the point of initializing that code.
> >
> > Any ideas how I can further narrow this down ?
>
> I assume that VIRTUAL_BUG_ON() triggers very early. Changing it to
> WARN_ON() should keep the machine alive and give you a hint which of
> those checks explodes.
I suspect an early console might be useful as well, in case the kernel doesn't
manage to boot.
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -50,7 +50,7 @@ void dump_mm(const struct mm_struct *mm);
> #endif
>
> #ifdef CONFIG_DEBUG_VIRTUAL
> -#define VIRTUAL_BUG_ON(cond) BUG_ON(cond)
> +#define VIRTUAL_BUG_ON(cond) WARN_ON(cond)
I'd make this WARN_ON_ONCE(), to see the first instance and to cross fingers
afterwards and maybe boot up.
Thanks,
Ingo
prev parent reply other threads:[~2015-07-11 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 14:50 CONFIG_DEBUG_VIRTUAL instant reboot Dave Jones
2015-07-11 8:13 ` Thomas Gleixner
2015-07-11 9:37 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150711093709.GA27975@gmail.com \
--to=mingo@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.