All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
	Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: Fix sense information setting in fixed sized format
Date: Sat, 11 Jul 2015 04:27:42 -0700	[thread overview]
Message-ID: <20150711112742.GA7883@infradead.org> (raw)
In-Reply-To: <1436367603-16456-1-git-send-email-sagig@mellanox.com>

On Wed, Jul 08, 2015 at 06:00:03PM +0300, Sagi Grimberg wrote:
> In fixed size sense format the information field is a four byte
> field.

This looks correct to me,

Reviewed-by: Christoph Hellwig <hch@lst.de>

But: this will truncate > 32bit sector numbers.  Maybe we need to
enable descriptor format sense data for large enough LUs.

  parent reply	other threads:[~2015-07-11 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 15:00 [PATCH] scsi: Fix sense information setting in fixed sized format Sagi Grimberg
2015-07-09 14:38 ` Bart Van Assche
2015-07-09 16:27 ` Martin K. Petersen
2015-07-11 11:27 ` Christoph Hellwig [this message]
2015-07-12  6:36   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150711112742.GA7883@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagig@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.