From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: kernel BUG at fs/9p/acl.c:96! 4.1.1 bz #94531 Date: Sat, 11 Jul 2015 19:55:25 +0100 Message-ID: <20150711185524.GI17109@ZenIV.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Sverd Johnsen Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:54327 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbbGKSz0 (ORCPT ); Sat, 11 Jul 2015 14:55:26 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 08, 2015 at 03:58:54PM +0200, Sverd Johnsen wrote: > I filed this a few months ago and can still be reproduced easily with > kernel 4.1.1: > > https://bugzilla.kernel.org/show_bug.cgi?id=94531 > > [ 224.248568] ------------[ cut here ]------------ > [ 224.252792] kernel BUG at fs/9p/acl.c:96! See if this fixes the sucker on your setup; it should've removed the inode from hash, since leaving it there means that the next attempt to look it up via iget5_locked() will just succeed, with no indication of failed inode setup... diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index 09e4433..e8aa57d 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c @@ -149,8 +149,7 @@ static struct inode *v9fs_qid_iget_dotl(struct super_block *sb, unlock_new_inode(inode); return inode; error: - unlock_new_inode(inode); - iput(inode); + iget_failed(inode); return ERR_PTR(retval); }