From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pan Xinhui <xinhuix.pan@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>,
"mnipxh@163.com" <mnipxh@163.com>
Subject: Re: [PATCH V2] acpi-cpufreq: Fix an acpi perf unregister issue
Date: Mon, 13 Jul 2015 07:58:59 +0530 [thread overview]
Message-ID: <20150713022859.GA10415@linux> (raw)
In-Reply-To: <559F67E4.7010509@intel.com>
On 10-07-15, 14:36, Pan Xinhui wrote:
>
> As policy->cpu may not be same in acpi_cpufreq_cpu_init and
> acpi_cpufreq_cpu_exit. There is a risk that we use different *cpu* to
> un/register acpi performance. So acpi_processor_unregister_performance
> may not be able to do the cleanup work. That causes a memory leak. And
> if there will be another acpi_processor_register_performance call, it
> may also fail thanks to the internal check of pr->performace.
>
> So we add a field *acpi_perf_cpu* to fix this issue.
>
> Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com>
> ---
> Change from V1:
> comments update
> ---
> drivers/cpufreq/acpi-cpufreq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
next prev parent reply other threads:[~2015-07-13 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 6:36 [PATCH V2] acpi-cpufreq: Fix an acpi perf unregister issue Pan Xinhui
2015-07-13 2:28 ` Viresh Kumar [this message]
2015-07-16 0:33 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713022859.GA10415@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mnipxh@163.com \
--cc=rjw@rjwysocki.net \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.