From: Amit Shah <amit.shah@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy
Date: Mon, 13 Jul 2015 11:39:38 +0530 [thread overview]
Message-ID: <20150713060938.GA17241@grmbl.mre> (raw)
In-Reply-To: <1436520840-28742-1-git-send-email-pagupta@redhat.com>
On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote:
> Timer was added in virtio-rng to rate limit the
> entropy. It used to trigger at regular intervals to
> bump up the quota value. The value of quota and timer
> slice is decided based on entropy source rate in host.
It doesn't necessarily depnd on the source rate in the host - all we
want the quota+timer to do is to limit the amount of data a guest can
take from the host - to ensure one (potentially rogue) guest does not
use up all the entropy from the host.
> This resulted in triggring of timer even when quota
> is not exhausted at all and resulting in extra processing.
>
> This patch triggers timer only when guest requests for
> entropy. As soon as first request from guest for entropy
> comes we set the timer. Timer bumps up the quota value
> when it gets triggered.
Can you say how you tested this?
Mainly interested in seeing the results in these cases:
* No quota/timer specified on command line
* Quota+timer specified on command line, and guest keeps asking host
for unlimited entropy, e.g. by doing 'dd if=/dev/hwrng of=/dev/null'
in the guest.
* Ensure quota restrictions are maintained, and we're not giving more
data than configured.
For these tests, it's helpful to use the host's /dev/urandom as the
source, since that can give data faster to the guest than the default
/dev/random. (Otherwise, if the host itself blocks on /dev/random,
the guest may not get entropy due to that reason vs it not getting
entropy due to rate-limiting.)
I tested one scenario using the trace events. With some quota and a
timer value specified on the cmdline, before patch, I get tons of
trace events before the guest is even up. After applying the patch, I
don't get any trace events. So that's progress!
I have one question:
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 15 ++++++++-------
> include/hw/virtio/virtio-rng.h | 1 +
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index 22b1d87..8774a0c 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -78,6 +78,12 @@ static void virtio_rng_process(VirtIORNG *vrng)
> return;
> }
>
> + if (vrng->activate_timer) {
> + timer_mod(vrng->rate_limit_timer,
> + qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + vrng->conf.period_ms);
> + vrng->activate_timer = false;
> + }
> +
> if (vrng->quota_remaining < 0) {
> quota = 0;
> } else {
> @@ -139,8 +145,7 @@ static void check_rate_limit(void *opaque)
>
> vrng->quota_remaining = vrng->conf.max_bytes;
> virtio_rng_process(vrng);
> - timer_mod(vrng->rate_limit_timer,
> - qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + vrng->conf.period_ms);
> + vrng->activate_timer = true;
> }
We're processing an older request first, and then firing the timer.
What's the use of doing it this way? Why even do this?
I know this is how the code was written originally, but since you've
looked at it, do you know why this is the way it is?
Amit
next prev parent reply other threads:[~2015-07-13 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 9:34 [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy Pankaj Gupta
2015-07-13 6:09 ` Amit Shah [this message]
2015-07-13 6:53 ` Pankaj Gupta
2015-07-13 7:34 ` Amit Shah
2015-07-13 7:55 ` Michael S. Tsirkin
2015-07-13 8:52 ` Amit Shah
2015-07-13 8:01 ` Pankaj Gupta
2015-07-13 8:47 ` Amit Shah
2015-07-13 8:58 ` Pankaj Gupta
2015-07-13 7:57 ` Michael S. Tsirkin
2015-07-13 8:06 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713060938.GA17241@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=pagupta@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.