From: Chao Peng <chao.p.peng@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
keir@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] x86: avoid invalid phys_proc_id reference
Date: Mon, 13 Jul 2015 17:52:47 +0800 [thread overview]
Message-ID: <20150713095247.GK3333@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <55A3992B020000780009004D@mail.emea.novell.com>
On Mon, Jul 13, 2015 at 09:55:39AM +0100, Jan Beulich wrote:
> >>> On 13.07.15 at 05:36, <chao.p.peng@linux.intel.com> wrote:
> > phys_proc_id is invalidated in remove_siblinginfo() which gets called
> > before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in
> > cpu_smpboot_free() is not possible to be correct.
> >
> > This patch invokes remove_siblinginfo() in cpu_smpboot_free(),
> > immediately after the use for cpu_to_socket(cpu).
>
> You having picked that variant of the two I proposed, did you verify
> that (as I said when talking about the alternative) there are no
> hidden dependencies? If you didn't, or if for whatever else reason
> there is any doubt, the less intrusive variant should be chosen at
> least for now.
I just did some basic tests but I don't think I can conclude that I
verified all the cases.
Because of this, I'm glad to follow your advice to have a gentle fix.
Chao
prev parent reply other threads:[~2015-07-13 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 3:36 [PATCH] x86: avoid invalid phys_proc_id reference Chao Peng
2015-07-13 8:55 ` Jan Beulich
2015-07-13 9:52 ` Chao Peng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713095247.GK3333@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.