All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/4] Makefile: add HOST_FIX_RPATH_HOOK to TARGET_FINALIZE_HOOKS
Date: Mon, 13 Jul 2015 13:28:21 +0300	[thread overview]
Message-ID: <20150713102821.GN2451@tarshish> (raw)
In-Reply-To: <1436782677-12557-2-git-send-email-s.martin49@gmail.com>

Hi Samuel,

On Mon, Jul 13, 2015 at 12:17:55PM +0200, Samuel Martin wrote:
> This patch adds host-patchelf as a target-finalize dependency, and
> introduces the HOST_FIX_RPATH_HOOK hook fixing the ELF files' RPATH of
> the host tree (excluding the sysroot).
> 
> After running this hook, the RPATH from any host ELF files is relative to
> the binary location itself.
> 
> Note that, we avoid to fix RPATH in the sysroot, and in the external
> toolcahin installation location.
> 
> As a first step toward a fully relocatable SDK, this change allows to get
> the toolchain relocatable, but not yet the whole SDK.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> 
> ---
> changes v2->v3:
> - move hook in Makefile (Baruch)
> ---
>  Makefile | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index daf692e..ac387ea 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -544,6 +544,18 @@ endif
>  
>  $(TARGETS_ROOTFS): target-finalize
>  
> +target-finalize: host-patchelf

Instead of duplicating the target-finalize target, why not add host-patchelf 
to $(PACKAGES) like we already do for host-localedef?

> +
> +define HOST_FIX_RPATH_HOOK
> +	$(TOPDIR)/support/scripts/fix_rpaths \
> +		set $(HOST_DIR) \
> +		--patchelf-program $(HOST_DIR)/usr/bin/patchelf \
> +		--libdirs $(HOST_DIR)/usr/lib \
> +		--exclude-dirs sysroot opt/ext-toolchain
> +endef
> +
> +TARGET_FINALIZE_HOOKS += HOST_FIX_RPATH_HOOK
> +
>  target-finalize: $(PACKAGES)
>  	@$(call MESSAGE,"Finalizing target directory")
>  	$(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-07-13 10:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 10:17 [Buildroot] [PATCH v3 1/4] support/scripts: add fix_rpaths Samuel Martin
2015-07-13 10:17 ` [Buildroot] [PATCH v3 2/4] Makefile: add HOST_FIX_RPATH_HOOK to TARGET_FINALIZE_HOOKS Samuel Martin
2015-07-13 10:28   ` Baruch Siach [this message]
2015-07-13 10:17 ` [Buildroot] [PATCH v3 3/4] Makefile: add TARGET_CLEAR_RPATH_HOOK " Samuel Martin
2015-07-13 10:17 ` [Buildroot] [PATCH v3 4/4] Makefile: staging symlink uses a relative path Samuel Martin
2015-07-13 10:24 ` [Buildroot] [PATCH v3 1/4] support/scripts: add fix_rpaths Baruch Siach
2015-07-13 10:31   ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713102821.GN2451@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.