From: Wolfram Sang <wsa@the-dreams.de>
To: Jiri Kosina <jkosina@suse.com>
Cc: Ellen Wang <ellen@cumulusnetworks.com>,
borneo.antonio@gmail.com, dbarksdale@uplogix.com,
linux-input@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1] HID: cp2112: fix byte order in SMBUS operations
Date: Mon, 13 Jul 2015 16:41:09 +0200 [thread overview]
Message-ID: <20150713144109.GA8115@katana> (raw)
In-Reply-To: <alpine.LNX.2.00.1507131322180.7522@pobox.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Mon, Jul 13, 2015 at 01:23:52PM +0200, Jiri Kosina wrote:
> On Thu, 9 Jul 2015, Ellen Wang wrote:
>
> > Change all occurrences of be16 to le16 in cp2112_xfer(),
> > because SMBUS words are little endian, not big endian.
> >
> > Signed-off-by: Ellen Wang <ellen@cumulusnetworks.com>
>
> Alright, this means that I2C_SMBUS_WORD_DATA and I2C_SMBUS_PROC_CALL have
> been terminally broken since the very beginning and noone noticed.
>
> Does this mean that those commands are in practice mostly unused anyway?
> This is important for 4.2 vs 4.3 consideration.
PROC_CALL is really rare. WORD_DATA depends on the setup, it is used.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-13 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:04 [PATCH v1] HID: cp2112: fix byte order in SMBUS operations Ellen Wang
2015-07-13 11:23 ` Jiri Kosina
2015-07-13 14:41 ` Wolfram Sang [this message]
2015-07-13 22:33 ` Ellen Wang
2015-07-14 20:43 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713144109.GA8115@katana \
--to=wsa@the-dreams.de \
--cc=borneo.antonio@gmail.com \
--cc=dbarksdale@uplogix.com \
--cc=ellen@cumulusnetworks.com \
--cc=jkosina@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.