From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Dmitry Torokhov <dtor@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nf: IDLETIMER: fix lockdep warning
Date: Mon, 13 Jul 2015 17:27:37 +0200 [thread overview]
Message-ID: <20150713152737.GA3628@salvia> (raw)
In-Reply-To: <CAE_wzQ-_bca+xowzFj0QZ11eXELftBVB+Lizeh=j-6pzWBdT_w@mail.gmail.com>
On Mon, Jul 13, 2015 at 08:02:36AM -0700, Dmitry Torokhov wrote:
> On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote:
> >> Dynamically allocated sysfs attributes should be initialized with
> >> sysfs_attr_init() otherwise lockdep will be angry with us:
> >>
> >> [ 45.468653] BUG: key ffffffc030fad4e0 not in .data!
> >> [ 45.468655] ------------[ cut here ]------------
> >> [ 45.468666] WARNING: CPU: 0 PID: 1176 at /mnt/host/source/src/third_party/kernel/v3.18/kernel/locking/lockdep.c:2991 lockdep_init_map+0x12c/0x490()
> >> [ 45.468672] DEBUG_LOCKS_WARN_ON(1)
> >> [ 45.468672] CPU: 0 PID: 1176 Comm: iptables Tainted: G U W 3.18.0 #43
> >> [ 45.468674] Hardware name: XXX
> >> [ 45.468675] Call trace:
> >> [ 45.468680] [<ffffffc0002072b4>] dump_backtrace+0x0/0x10c
> >> [ 45.468683] [<ffffffc0002073d0>] show_stack+0x10/0x1c
> >> [ 45.468688] [<ffffffc000a86cd4>] dump_stack+0x74/0x94
> >> [ 45.468692] [<ffffffc000217ae0>] warn_slowpath_common+0x84/0xb0
> >> [ 45.468694] [<ffffffc000217b84>] warn_slowpath_fmt+0x4c/0x58
> >> [ 45.468697] [<ffffffc0002530a4>] lockdep_init_map+0x128/0x490
> >> [ 45.468701] [<ffffffc000367ef0>] __kernfs_create_file+0x80/0xe4
> >> [ 45.468704] [<ffffffc00036862c>] sysfs_add_file_mode_ns+0x104/0x170
> >> [ 45.468706] [<ffffffc00036870c>] sysfs_create_file_ns+0x58/0x64
> >> [ 45.468711] [<ffffffc000930430>] idletimer_tg_checkentry+0x14c/0x324
> >> [ 45.468714] [<ffffffc00092a728>] xt_check_target+0x170/0x198
> >> [ 45.468717] [<ffffffc000993efc>] check_target+0x58/0x6c
> >> [ 45.468720] [<ffffffc000994c64>] translate_table+0x30c/0x424
> >> [ 45.468723] [<ffffffc00099529c>] do_ipt_set_ctl+0x144/0x1d0
> >> [ 45.468728] [<ffffffc0009079f0>] nf_setsockopt+0x50/0x60
> >> [ 45.468732] [<ffffffc000946870>] ip_setsockopt+0x8c/0xb4
> >> [ 45.468735] [<ffffffc0009661c0>] raw_setsockopt+0x10/0x50
> >> [ 45.468739] [<ffffffc0008c1550>] sock_common_setsockopt+0x14/0x20
> >> [ 45.468742] [<ffffffc0008bd190>] SyS_setsockopt+0x88/0xb8
> >> [ 45.468744] ---[ end trace 41d156354d18c039 ]---
> >
> > Applied, thanks.
> >
> > One question:
> >
> >> Change-Id: I1da5cd96fc8e1e1e4209e81eba1165a42d4d45e9
> >
> > BTW, does this gerrit change ID provide any public information? Thanks.
>
> Argh, I am sorry, I forgot to clean this out when mailing the patch.
> In this particular case you can find the change in AOSP gerrit at
> https://android-review.googlesource.com but without such context this
> change-id is of course useless.
No problem, I'll remove it. Thanks Dmitry.
prev parent reply other threads:[~2015-07-13 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 0:15 [PATCH] nf: IDLETIMER: fix lockdep warning Dmitry Torokhov
2015-07-13 13:20 ` Pablo Neira Ayuso
2015-07-13 15:02 ` Dmitry Torokhov
2015-07-13 15:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713152737.GA3628@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dtor@google.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.