From: Meador Inge <meadori@codesourcery.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used
Date: Mon, 13 Jul 2015 13:08:02 -0700 [thread overview]
Message-ID: <20150713200801.GA24071@mentor.com> (raw)
In-Reply-To: <559ADA58.9020409@vivier.eu>
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote:
> Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h
On second thought, I was following an existing pattern in 'main.c'. Really
fixing this would require changing around 30 other locations too. I think
if we are going to switch to the EXIT_* macros, then the whole file should
be changed in one patch and making that fix shouldn't hold this patch up.
-- Meador
next prev parent reply other threads:[~2015-07-13 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 18:03 [Qemu-devel] [PATCH 0/4] linux-user: CLI cleanup meadori
2015-07-06 18:03 ` [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used meadori
2015-07-06 19:43 ` Laurent Vivier
2015-07-08 20:02 ` Meador Inge
2015-07-13 20:08 ` Meador Inge [this message]
2015-09-28 13:22 ` Riku Voipio
2015-07-06 18:03 ` [Qemu-devel] [PATCH 2/4] linux-user: Add -help meadori
2015-07-06 18:03 ` [Qemu-devel] [PATCH 3/4] linux-user: Add proper error messages for bad options meadori
2015-07-06 18:03 ` [Qemu-devel] [PATCH 4/4] linux-user: Treat --foo options the same as -foo meadori
2015-07-06 19:59 ` [Qemu-devel] [PATCH 0/4] linux-user: CLI cleanup Laurent Vivier
2015-09-28 13:15 ` Riku Voipio
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 22:44 [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup Meador Inge
2012-03-27 22:44 ` [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used Meador Inge
2012-05-07 14:50 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713200801.GA24071@mentor.com \
--to=meadori@codesourcery.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.