From: Oleg Nesterov <oleg@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] introduce sb_unlock_frozen()
Date: Mon, 13 Jul 2015 23:25:52 +0200 [thread overview]
Message-ID: <20150713212552.GA13876@redhat.com> (raw)
In-Reply-To: <20150713212536.GA13855@redhat.com>
Preaparation. Add the trivial helper which does the wakeup.
---
fs/super.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 5ea0edd..c23bafc 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1254,6 +1254,12 @@ static void sb_wait_write(struct super_block *sb, int level)
} while (writers);
}
+static void sb_unlock_frozen(struct super_block *sb)
+{
+ smp_wmb();
+ wake_up(&sb->s_writers.wait_unfrozen);
+}
+
/**
* freeze_super - lock the filesystem and force it into a consistent state
* @sb: the super to lock
@@ -1340,8 +1346,7 @@ int freeze_super(struct super_block *sb)
printk(KERN_ERR
"VFS:Filesystem freeze failed\n");
sb->s_writers.frozen = SB_UNFROZEN;
- smp_wmb();
- wake_up(&sb->s_writers.wait_unfrozen);
+ sb_unlock_frozen(sb);
deactivate_locked_super(sb);
return ret;
}
@@ -1387,8 +1392,7 @@ int thaw_super(struct super_block *sb)
out:
sb->s_writers.frozen = SB_UNFROZEN;
- smp_wmb();
- wake_up(&sb->s_writers.wait_unfrozen);
+ sb_unlock_frozen(sb);
deactivate_locked_super(sb);
return 0;
--
1.5.5.1
next prev parent reply other threads:[~2015-07-13 21:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 21:25 [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore Oleg Nesterov
2015-07-13 21:25 ` [PATCH 1/4] change get_super_thawed() to use sb_start/end_write() Oleg Nesterov
2015-07-14 10:49 ` Jan Kara
2015-07-14 13:38 ` Oleg Nesterov
2015-07-13 21:25 ` Oleg Nesterov [this message]
2015-07-13 21:25 ` [PATCH 3/4] introduce sb_lockdep_release() Oleg Nesterov
2015-07-13 21:25 ` [PATCH 4/4] change sb_writers to use percpu_rw_semaphore Oleg Nesterov
2015-07-13 22:23 ` [PATCH RFC 0/4] " Dave Chinner
2015-07-13 22:42 ` Oleg Nesterov
2015-07-13 23:14 ` Dave Chinner
2015-07-14 10:48 ` Jan Kara
2015-07-14 13:37 ` Oleg Nesterov
2015-07-14 21:17 ` Dave Hansen
2015-07-14 21:22 ` Oleg Nesterov
2015-07-14 21:41 ` Dave Hansen
2015-07-15 6:47 ` Jan Kara
2015-07-15 18:19 ` Oleg Nesterov
2015-07-16 7:26 ` Jan Kara
2015-07-16 7:30 ` Dave Hansen
2015-07-16 8:55 ` Jan Kara
2015-07-16 17:32 ` Oleg Nesterov
2015-07-17 1:27 ` Dave Chinner
2015-07-17 17:31 ` Oleg Nesterov
2015-07-17 22:40 ` Dave Chinner
2015-07-20 8:26 ` Jan Kara
2015-07-22 21:09 ` Oleg Nesterov
2015-07-20 16:23 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713212552.GA13876@redhat.com \
--to=oleg@redhat.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=dave@stgolabs.net \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.