From: David Weinehall <david.weinehall@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Allow parsing of variable size child device entries from VBT
Date: Tue, 14 Jul 2015 10:11:37 +0300 [thread overview]
Message-ID: <20150714071136.GC21083@boom> (raw)
In-Reply-To: <20150713092446.GY3736@phenom.ffwll.local>
On Mon, Jul 13, 2015 at 11:24:46AM +0200, Daniel Vetter wrote:
> On Fri, Jul 10, 2015 at 02:10:54PM +0300, Antti Koskipaa wrote:
> > VBT version 196 increased the size of common_child_dev_config. The parser
> > code assumed that the size of this structure would not change.
> >
> > So now, instead of checking for smaller size, check that the VBT entry is
> > not too large and memcpy only child_dev_size amount of data, leaving any
> > trailing entries as zero. If this is not good enough for the future,
> > we can always sprinkle extra version checks in there.
> >
> > Signed-off-by: Antti Koskipaa <antti.koskipaa@linux.intel.com>
>
> As I mentioned in the other threads I think with vbt it's not too paranoid
> to double-check our assumptions. So for each vbt version range I'd like us
> to check what size we exactly expect. Being super paranoid with vbt is imo
> good practice since otherwise the hw teams will sneak in another update
> without us realizing it.
Antti's on vacation now for the next few weeks. Do you need these
modifications as a pre-requisite for merging his patch, or can further
improvements be submitted separately?
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-14 7:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 11:10 [PATCH 0/2] VBT and I_boost fixes Antti Koskipaa
2015-07-10 11:10 ` [PATCH 1/2] drm/i915: Allow parsing of variable size child device entries from VBT Antti Koskipaa
2015-07-10 12:32 ` David Weinehall
2015-07-13 9:24 ` Daniel Vetter
2015-07-14 7:11 ` David Weinehall [this message]
2015-07-14 8:01 ` Daniel Vetter
2015-08-04 13:55 ` [PATCH 1/2 v2] " David Weinehall
2015-08-05 8:59 ` Daniel Vetter
2015-08-05 15:32 ` David Weinehall
2015-08-06 12:18 ` Daniel Vetter
2015-08-06 14:12 ` David Weinehall
2015-08-06 13:59 ` Michel Thierry
2015-08-06 14:08 ` David Weinehall
2015-08-06 15:31 ` Daniel Vetter
2015-08-12 10:29 ` [PATCH 1/2 v2 addendum] " David Weinehall
2015-08-12 12:13 ` Jani Nikula
2015-08-13 10:30 ` David Weinehall
2015-08-13 11:35 ` Jani Nikula
2015-08-12 14:19 ` Jani Nikula
2015-08-13 13:14 ` [PATCH 1/2 v2 addendum v2] " David Weinehall
2015-08-14 8:07 ` Timo Aaltonen
2015-08-14 8:42 ` Jani Nikula
2015-08-14 9:40 ` Jani Nikula
2015-07-10 11:10 ` [PATCH 2/2] drm/i915: Per-DDI I_boost override Antti Koskipaa
2015-08-06 14:11 ` David Weinehall
2015-08-06 15:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714071136.GC21083@boom \
--to=david.weinehall@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.