From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF2Oo-0000Ti-Tx for qemu-devel@nongnu.org; Tue, 14 Jul 2015 11:45:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF2On-0000dJ-Eb for qemu-devel@nongnu.org; Tue, 14 Jul 2015 11:45:38 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:41429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF2On-0000cl-23 for qemu-devel@nongnu.org; Tue, 14 Jul 2015 11:45:37 -0400 Date: Tue, 14 Jul 2015 17:45:35 +0200 From: Aurelien Jarno Message-ID: <20150714154535.GA29067@aurel32.net> References: <1436868495-4359-1-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436868495-4359-1-git-send-email-leon.alrae@imgtec.com> Subject: Re: [Qemu-devel] [PATCH] target-mips: correct DERET instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: qemu-devel@nongnu.org On 2015-07-14 11:08, Leon Alrae wrote: > Fix Debug Mode flag clearing, and when DERET is placed between LL and SC > do not make SC fail. > > Signed-off-by: Leon Alrae > --- > target-mips/op_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index 2a9ddff..d461ad8 100644 > --- a/target-mips/op_helper.c > +++ b/target-mips/op_helper.c > @@ -2154,10 +2154,9 @@ void helper_deret(CPUMIPSState *env) > debug_pre_eret(env); > set_pc(env, env->CP0_DEPC); > > - env->hflags &= MIPS_HFLAG_DM; > + env->hflags &= ~MIPS_HFLAG_DM; > compute_hflags(env); > debug_post_eret(env); > - env->lladdr = 1; > } > #endif /* !CONFIG_USER_ONLY */ Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net